Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RST line is not used even when configured #33

Open
ghost opened this issue Jul 17, 2024 · 1 comment
Open

RST line is not used even when configured #33

ghost opened this issue Jul 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 17, 2024

If you specify the RST line, it is configured in init, but the reset() function is never called from _init() or indeed anywhere else, leaving the RST line driven low - ie, display is in reset.

You can't neatly work around this by calling reset() from your code, because it will happen after the SPI setup commands have been sent.

The fix would be to call reset() at the top of _init() in the driver.

@Gadgetoid Gadgetoid added the bug Something isn't working label Nov 11, 2024
@Gadgetoid
Copy link
Member

Diff with the library before changes suggests reset was called right after setting it up, if it's supplied. Should probably do that! 😬

Gadgetoid added a commit that referenced this issue Nov 11, 2024
Fix regression raised in #33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant