Replies: 2 comments 1 reply
-
I guess this change cannot be implemented as optional, right? |
Beta Was this translation helpful? Give feedback.
1 reply
-
Well a total of 7 people participated which is quite low. The total majority also voted on not to change anything - so I will not change anything: |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Based on the discussion comment #259 (reply in thread) I want to know your opinion on the topic of security.
Currently the reading and writing API often use the same URL pattern (like
/{ServiceGroupId}
) just with a different HTTP verb (GET
,PUT
andDELETE
) - see https://github.com/phax/phoss-smp/wiki/REST-API for all details.Now I am wondering if the next major version of phoss SMP (v8) should define a constant path prefix (like
/api
) for the writable API (everything usingPUT
andDELETE
). That would mean (at least):For example the API
PUT /{ServiceGroupId}
would be changed toPUT /api/{ServiceGroupId}
.Additionally, if you are positive on the above topic, should all the non-standard
GET
(reading) API calls also be moved to a special path like/api
? That would also effect APIs likeGET /complete/{ServiceGroupId}
etc.The impact of that is very similar to the above one.
The only APIs that can NOT be moved are the standardized ones. These are currently (from a Peppol API perspective):
GET /{ServiceGroupId}
GET /{ServiceGroupId}/services/{DocumentTypeId}
GET /businesscard/{ServiceGroupId}
7 votes ·
Beta Was this translation helpful? Give feedback.
All reactions