V3 - DO NOT MERGE #2525

BupycHuk · 2023-10-07T08:51:08Z

This PR is created to pull changes from main branch to v3 using github's UI features.

DO NOT MERGE

# Conflicts: # docs/api/dbaas/dbaas.md # docs/dbaas/olm.md # go.mod # managed/models/database.go

# Conflicts: # managed/services/dbaas/kubernetes/client/mock_kube_client_connector.go # managed/services/management/dbaas/mock_components_service_test.go # managed/services/management/dbaas/mock_dbaas_client_test.go # managed/services/management/dbaas/mock_grafana_client_test.go # managed/services/management/dbaas/mock_kube_storage_manager_test.go # managed/services/management/dbaas/mock_kubernetes_client_test.go # managed/services/management/dbaas/mock_version_service_test.go

codecov · 2023-10-07T08:53:24Z

Codecov Report

Attention: Patch coverage is 20.87254% with 925 lines in your changes missing coverage. Please review.

Project coverage is 43.53%. Comparing base (815c7ef) to head (fb01dfa).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
agent/client/client.go	17.72%	65 Missing ⚠️
admin/commands/management/add_postgresql.go	0.00%	42 Missing ⚠️
admin/commands/management/add_mysql.go	0.00%	41 Missing ⚠️
admin/commands/management/add_mongodb.go	0.00%	40 Missing ⚠️
...min/commands/management/add_external_serverless.go	0.00%	31 Missing ⚠️
admin/commands/management/remove.go	0.00%	28 Missing ⚠️
admin/commands/management/add_proxysql.go	0.00%	27 Missing ⚠️
agent/agents/supervisor/supervisor.go	51.78%	27 Missing ⚠️
...ent/agents/postgres/pgstatmonitor/pgstatmonitor.go	0.00%	26 Missing ⚠️
...n/commands/inventory/add_agent_mongodb_exporter.go	0.00%	23 Missing ⚠️
... and 68 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
+ Coverage   42.04%   43.53%   +1.49%     
==========================================
  Files         399      366      -33     
  Lines       50722    44169    -6553     
==========================================
- Hits        21325    19229    -2096     
+ Misses      27389    23254    -4135     
+ Partials     2008     1686     -322

Flag	Coverage Δ
admin	`11.47% <1.14%> (-0.08%)`	⬇️
vmproxy	`68.57% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

# Conflicts: # go.mod # go.sum

* PMM-11079 Remove Integrated Alerting * PMM-11079 Cleanup IA leftovwers * PMM-11079 Regenerate * PMM-11079 Fix * PMM-11079 Refactoring and fixes * PMM-11079 Fix tests * PMM-11079 go mod tidy * PMM-11079 Fix API tests * PMM-11079 Cleanup * PMM-11079 Fixes * PMM-11079 Fix tests * PMM-11079 Fix tests * PMM-11079 Fix tests * PMM-11079 Fix tests * PMM-11079 Hit CI * PMM-11079 Revert nolint * PMM-11079 Remove IA migration script * PMM-11079 Cleanup * PMM-11079 Cleanup * PMM-11079 Refactoring and cleanup * PMM-11079 Cleanup * PMM-11079 Cleanup after merge

commit 49b9bb4 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 1 13:24:42 2023 +0300 Bump github.com/aws/aws-sdk-go from 1.46.0 to 1.47.0 (#2588) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.46.0 to 1.47.0. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.46.0...v1.47.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1acf7b2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Nov 1 11:57:57 2023 +0200 Bump github.com/grafana/grafana-api-golang-client from 0.24.0 to 0.25.0 (#2587) Bumps [github.com/grafana/grafana-api-golang-client](https://github.com/grafana/grafana-api-golang-client) from 0.24.0 to 0.25.0. - [Release notes](https://github.com/grafana/grafana-api-golang-client/releases) - [Commits](grafana/grafana-api-golang-client@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: github.com/grafana/grafana-api-golang-client dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1cca6f9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 31 16:32:52 2023 +0300 Bump github.com/docker/docker in /tools (#2583) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.6+incompatible to 24.0.7+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.6...v24.0.7) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3f5dc68 Author: Nurlan Moldomurov <[email protected]> Date: Tue Oct 31 15:12:58 2023 +0300 PMM-12631 removed alertmanager configs from logs. (#2584) * PMM-12631 removed alertmanager configs from logs. * PMM-12631 removed alertmanager configs from tests and docs. * PMM-12631 Fix linter. commit 353542d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 31 11:17:34 2023 +0000 Bump github.com/ClickHouse/clickhouse-go/v2 from 2.13.0 to 2.15.0 (#2580) * Bump github.com/ClickHouse/clickhouse-go/v2 from 2.13.0 to 2.15.0 Bumps [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) from 2.13.0 to 2.15.0. - [Release notes](https://github.com/ClickHouse/clickhouse-go/releases) - [Changelog](https://github.com/ClickHouse/clickhouse-go/blob/main/CHANGELOG.md) - [Commits](ClickHouse/clickhouse-go@v2.13.0...v2.15.0) --- updated-dependencies: - dependency-name: github.com/ClickHouse/clickhouse-go/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artem Gavrilov <[email protected]> commit d08e47b Author: Vadim Yalovets <[email protected]> Date: Tue Oct 31 10:09:02 2023 +0200 PMM-12630 UI upgrade from 2.37.1 and lower does not work (#2582) commit bc802b4 Author: Jiří Čtvrtka <[email protected]> Date: Mon Oct 30 11:32:51 2023 +0100 PMM-12632 Fix agent client response. (#2581) * PMM-12632 Fix agent client response. * PMM-12632 Required changes. commit 1d326ec Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 30 10:22:15 2023 +0100 Bump github.com/google/uuid from 1.3.1 to 1.4.0 (#2579) Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.3.1 to 1.4.0. - [Release notes](https://github.com/google/uuid/releases) - [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md) - [Commits](google/uuid@v1.3.1...v1.4.0) --- updated-dependencies: - dependency-name: github.com/google/uuid dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d01ea55 Author: Vadim Yalovets <[email protected]> Date: Thu Oct 26 13:01:32 2023 +0300 PMM-12626 Packages built using old go version (#2576) * PMM-12626 Packages built using old go version * PMM-12626 Packages built using old go version commit 828153c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Oct 26 11:40:55 2023 +0200 Bump google.golang.org/grpc from 1.58.0 to 1.58.3 in /tools (#2577) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.0 to 1.58.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.0...v1.58.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a3a52c1 Author: rishat-ishbulatov <[email protected]> Date: Wed Oct 25 22:02:42 2023 +0300 PMM-8655 Send unsent messages after connection problems (#1970) * PMM-8655 feat: config with cache * PMM-8655 feat: client domain models * PMM-8655 feat: buffer-ring with bigqueue * PMM-8655 feat: cache and dummy * PMM-8655 ref: client * PMM-8655 feat: cache connection response * PMM-8655 fix: sum, datarace for bigqueue * PMM-8655 ref: temp commented channel test on corrupted utf * Update config.go * Update go.sum * PMM-8655 Fix linters. * Update agent/client/cache/cache.go Co-authored-by: Alex Tymchuk <[email protected]> * PMM-8655 Fix linters. * PMM-8655 remove unused field. * PMM-8655 Address review comments. * PMM-8655 get rid of goto operator. * PMM-8655 fix go.sum. * PMM-8655 fix go.sum. * PMM-8655 fix tests and linter. * revert label renaming * revert channel_test.go * PMM-8655 revert test. * PMM-8655 Fix linters. * PMM-8655 Fix linters. * PMM-8655 Fix linters. --------- Co-authored-by: Nurlan Moldomurov <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]> Co-authored-by: Alex Tymchuk <[email protected]> Co-authored-by: Talha Bin Rizwan <[email protected]> commit 46626e6 Author: Alex Demidoff <[email protected]> Date: Wed Oct 25 20:14:41 2023 +0300 PMM-12185 migrate telemetry GrafanaDS to using PostgreSQL (#2542) * PMM-12185 migrate telemetry GrafanaDS to using PostgreSQL * PMM-12185 configure GrafanaDB connection * PMM-12185 fix grafanaDB SQL stmnts * PMM-12185 don't init when ds is disabled * PMM-12185 cleanup the code * PMM-12185 update go modules * PMM-12185 Apply suggestions from code review Co-authored-by: Nurlan Moldomurov <[email protected]> * PMM-12185 remove the debug stmnt * PMM-12185 remove unused lint suppressions * PMM-12185 fix inconsistent log output * PMM-12185 trim trailing spaces * PMM-12185 rename VM config type for consistency sake --------- Co-authored-by: Nurlan Moldomurov <[email protected]> commit 23571ee Author: Francisco Miguel Biete Banon <[email protected]> Date: Wed Oct 25 17:57:16 2023 +0100 Missing settings to use keepalive in some locations (#2575) We have keepalives enabled in upstream blocks, but some of the locations are missing the proxy changes required to use it. [10 top nginx configuration mistakes](https://www.nginx.com/blog/avoiding-top-10-nginx-configuration-mistakes/#no-keepalives) commit 4346c6f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Oct 25 09:49:34 2023 +0000 Bump @typescript-eslint/parser from 6.8.0 to 6.9.0 in /cli-tests (#2570) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.9.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 71879ab Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Oct 25 11:14:13 2023 +0300 Bump github.com/brianvoe/gofakeit/v6 from 6.23.0 to 6.24.0 (#2565) Bumps [github.com/brianvoe/gofakeit/v6](https://github.com/brianvoe/gofakeit) from 6.23.0 to 6.24.0. - [Release notes](https://github.com/brianvoe/gofakeit/releases) - [Commits](brianvoe/gofakeit@v6.23.0...v6.24.0) --- updated-dependencies: - dependency-name: github.com/brianvoe/gofakeit/v6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiří Čtvrtka <[email protected]> commit 5730e16 Author: Alex Demidoff <[email protected]> Date: Tue Oct 24 21:11:40 2023 +0300 PMM-12375 add database version to services (#2488) * PMM-12375 create serviceInfoBroker component * PMM-12375 serviceInfoBroker won't ping the db * PMM-12375 fix the test * PMM-12375 add tests for serviceInfoBroker * PMM-12375 fix the agent tests * PMM-12375 fix agent tests, server-side * PMM-12375 fix services tests * PMM-12375 do not update if version is empty * PMM-12375 remove the unused parameter * PMM-12375 remove the version from Stats * PMM-12375 add message type processing to channel * PMM-12375 update codeowners * PMM-12375 respect skipConnectionCheck, simpler schema * PMM-12375 fix linter warnings * PMM-12375 fix license headers * PMM-12375 respect skipConnectionCheck param * PMM-12375 minor fixes * PMM-12375 update the docs * PMM-12375 do not run serviceInfo for older clients * PMM-12375 add serviceInfoBroker to rds * PMM-12375 add serviceInfoBroker to azure * PMM-12375 add version to ListServices result * PMM-12375 a minor fix in teardown fn * PMM-12375 cleanup the inevntory_metrics_test * PMM-12375 follow up on review * PMM-12375 revert changes, move to other PRs * PMM-12375 revert changed related to linter * PMM-12375 make version nullable * PMM-12375 do not call FindService when skipping connection check * PMM-12375 fix pointer reference * PMM-12375 re-generate interfaces * PMM-12375 fix a dereference * PMM-12375 make ServiceInfoBroker work for older agents * PMM-12375 fix the linter error * PMM-12375 follow up on review * PMM-12375 a few corrections to managed's readme.md * PMM-12375 fix the mock file version * PMM-12375 bump up the compatibility version * PMM-12375 regen the mockfiles * PMM-12375 remove debug msg * Fix linter --------- Co-authored-by: Alex Tymchuk <[email protected]> Co-authored-by: Alex Demidoff <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]> commit be137c9 Author: Artem Gavrilov <[email protected]> Date: Tue Oct 24 15:48:07 2023 +0200 PMM-7 Update golang up to 1.21.3 (#2569) Co-authored-by: Jiří Čtvrtka <[email protected]> commit 330a37b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 24 13:40:01 2023 +0000 Bump @typescript-eslint/eslint-plugin from 6.8.0 to 6.9.0 in /cli-tests (#2571) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.9.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiří Čtvrtka <[email protected]> commit 0f463f8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 24 15:29:08 2023 +0200 Bump eslint-plugin-import from 2.28.0 to 2.29.0 in /cli-tests (#2572) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.28.0 to 2.29.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.28.0...v2.29.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7fa52c3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 23 09:14:22 2023 +0000 Bump eslint from 8.51.0 to 8.52.0 in /cli-tests (#2567) Bumps [eslint](https://github.com/eslint/eslint) from 8.51.0 to 8.52.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.51.0...v8.52.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit db41410 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 23 10:51:22 2023 +0200 Bump eslint-plugin-playwright from 0.17.0 to 0.18.0 in /cli-tests (#2566) Bumps [eslint-plugin-playwright](https://github.com/playwright-community/eslint-plugin-playwright) from 0.17.0 to 0.18.0. - [Release notes](https://github.com/playwright-community/eslint-plugin-playwright/releases) - [Changelog](https://github.com/playwright-community/eslint-plugin-playwright/blob/main/CHANGELOG.md) - [Commits](playwright-community/eslint-plugin-playwright@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: eslint-plugin-playwright dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3029ae9 Merge: c3cb1a7 12ce642 Author: Nurlan Moldomurov <[email protected]> Date: Sat Oct 21 22:23:55 2023 +0300 Merge branch 'pmm-2.40.1' commit c3cb1a7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Oct 20 15:46:26 2023 +0300 Bump github.com/aws/aws-sdk-go from 1.45.2 to 1.46.0 (#2562) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.45.2 to 1.46.0. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.45.2...v1.46.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 12ce642 Author: Nurlan Moldomurov <[email protected]> Date: Fri Oct 20 15:40:13 2023 +0300 PMM-7 ignore errors on not really necessary step. (#2564) commit aef2236 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Oct 18 16:39:38 2023 +0300 Bump github.com/prometheus/common from 0.44.0 to 0.45.0 (#2561) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.44.0 to 0.45.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.44.0...v0.45.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 85ca980 Author: Nurlan Moldomurov <[email protected]> Date: Wed Oct 18 14:07:05 2023 +0300 PMM-12587 Fix drop DB for EL7. (#2560) commit 763b4cc Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Oct 18 13:45:58 2023 +0300 Bump google.golang.org/grpc from 1.58.0 to 1.59.0 (#2559) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.0 to 1.59.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.0...v1.59.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 09071bf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Oct 18 10:12:26 2023 +0000 Bump github.com/vektra/mockery/v2 from 2.35.1 to 2.36.0 in /tools (#2552) * Bump github.com/vektra/mockery/v2 from 2.35.1 to 2.36.0 in /tools Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.35.1 to 2.36.0. - [Release notes](https://github.com/vektra/mockery/releases) - [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md) - [Commits](vektra/mockery@v2.35.1...v2.36.0) --- updated-dependencies: - dependency-name: github.com/vektra/mockery/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * make gen * trigger --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiří Čtvrtka <[email protected]> Co-authored-by: Jiří Čtvrtka <[email protected]> commit 877cd07 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 17 10:03:44 2023 +0000 Bump @typescript-eslint/parser from 6.7.0 to 6.8.0 in /cli-tests (#2555) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.7.0 to 6.8.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.8.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8687f25 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 17 09:52:48 2023 +0000 Bump @typescript-eslint/eslint-plugin from 6.7.0 to 6.8.0 in /cli-tests (#2554) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.7.0 to 6.8.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.8.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit e721197 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 17 11:39:59 2023 +0200 Bump eslint-plugin-playwright from 0.16.0 to 0.17.0 in /cli-tests (#2553) Bumps [eslint-plugin-playwright](https://github.com/playwright-community/eslint-plugin-playwright) from 0.16.0 to 0.17.0. - [Release notes](https://github.com/playwright-community/eslint-plugin-playwright/releases) - [Changelog](https://github.com/playwright-community/eslint-plugin-playwright/blob/main/CHANGELOG.md) - [Commits](playwright-community/eslint-plugin-playwright@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: eslint-plugin-playwright dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9564347 Author: Nurlan Moldomurov <[email protected]> Date: Tue Oct 17 12:36:37 2023 +0300 PMM-12576 change admin ID to 1. (#2551) * PMM-12576 change admin ID to 1. * PMM-12576 Debug messages. commit 578bab3 Author: Nurlan Moldomurov <[email protected]> Date: Tue Oct 17 00:14:21 2023 +0300 PMM-12592 PMM-12587 fix SQLite to PostgreSQL (#2549) * PMM-7 More debug data. * PMM-12584 fix hex values in PostgreSQL DB. * PMM-12588 Outdated grafana-db-migrator used (#2547) * PMM-12584 fix provisioning problem. * PMM-12584 fix drop database issue. * PMM-12584 fix drop database issue for EL7. * PMM-12584 fix drop database issue for EL7. * PMM-12584 fix drop database issue for EL7. * Update update/ansible/playbook/tasks/roles/sqlite-to-postgres/tasks/main.yml Co-authored-by: Alex Demidoff <[email protected]> --------- Co-authored-by: Vadim Yalovets <[email protected]> Co-authored-by: Alex Demidoff <[email protected]> commit 79357f3 Author: Artem Gavrilov <[email protected]> Date: Tue Sep 26 16:05:44 2023 +0200 PMM-7 Fix datarace (#2501) * PMM-7 Fix datarace * PMM-7 Fix datarace commit d58294a Author: Alex Demidoff <[email protected]> Date: Mon Oct 16 15:46:45 2023 +0300 PMM-7 fix API tests (#2550) * PMM-7 fix API tests Why: PMM API tests currently fail. Namely, `TestDownloadLogs` fails with the following diff: 12:38:56 Diff: 12:38:56 --- Expected 12:38:56 +++ Actual 12:38:56 @@ -1,2 +1,2 @@ 12:38:56 -([]string) (len=38) { 12:38:56 +([]string) (len=39) { 12:38:56 (string) (len=21) "alertmanager.base.yml", 12:38:56 @@ -5,2 +5,3 @@ 12:38:56 (string) (len=16) "alertmanager.yml", 12:38:56 + (string) (len=25) "clickhouse-server.err.log", 12:38:56 (string) (len=21) "clickhouse-server.log", 12:38:56 Test: TestDownloadLogs 12:38:56 --- FAIL: TestDownloadLogs (0.56s) * PMM-7 disable the rotation config commit 071946e Author: Nurlan Moldomurov <[email protected]> Date: Wed Oct 11 00:38:08 2023 +0300 PMM-12562 Show error 503 instead of 500. commit cf67816 Author: Nurlan Moldomurov <[email protected]> Date: Sun Oct 15 23:14:36 2023 +0300 PMM-12223 Update clickhouse. (#2489) * PMM-12223 Update clickhouse. * PMM-12223 update logs path commit 58efa80 Author: Alex Demidoff <[email protected]> Date: Sat Oct 14 00:32:23 2023 +0300 PMM-12463 Add telemetry envvar datasource (#2532) * PMM-12463 allow ireturn on DataSources * PMM-12463 fix some command hints * PMM-12463 add ENV_VAR dataSource * PMM-12463 add a provisionary envvar metrics extraction * PMM-12463 add a test for EnvVar datasource * PMM-12463 revert staticckeck linter * PMM-12463 fix linter warnings * PMM-12463 revert changes to main.go * PMM-12463 refactor the output format * PMM-12463 add a transform to strip values * PMM-12463 fix linter warnings * PMM-12463 refactor transform, add tests * PMM-12463 run format * PMM-12463 follow up on review comments * PMM-12185 remove the debug statement * PMM-12185 don't be too noisy when a ds is not initialized commit 40e0fcf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Oct 12 09:52:50 2023 +0000 Bump golang.org/x/net from 0.16.0 to 0.17.0 (#2541) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.16.0 to 0.17.0. - [Commits](golang/net@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit df0c351 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Oct 12 11:33:00 2023 +0200 Bump golang.org/x/net from 0.16.0 to 0.17.0 in /tools (#2540) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.16.0 to 0.17.0. - [Commits](golang/net@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d974ff8 Author: Vishwas Sharma <[email protected]> Date: Wed Oct 11 20:13:25 2023 +0530 Enable errcheck linter rule (#2470) * Install the CodeSee workflow. Learn more at https://docs.codesee.io * removed the codesee-arch-diagram.yml~ * enable errcheck linter on anew branch because old branch was not made from main branch * made change in file proxy.go located at vmproxy/proxy/proxy.go * made change in file admin/pkg/client/tarball/tarball.go located at admin/pkg/client/tarball/tarball.go * made change in file proxy_test.go located at vmproxy/proxy/proxy_test.go * made change in file proxy_test.go located at vmproxy/proxy/proxy_test.go * made change in file database.go located at managed/services/dbaas/kubernetes/client/database/database.go * made change in file percona_sso_model_helpers.go located at managed/models/percona_sso_model_helpers.go * made change in file api-tests/server/auth_test.go located at api-tests/server/auth_test.go * made change in file api-tests/server/auth_test.go located at api-tests/server/auth_test.go * made change in file admin/commands/summary.go located at admin/commands/summary.go * made change in file job_helpers_test.go located at managed/models/job_helpers_test.go * made change in file datasources.go located at managed/services/telemetry/datasources.go * made change in file datasources.go located at managed/services/telemetry/datasources.go * made change in file main.go located at qan-api2/main.go * made change in file main.go located at qan-api2/main.go * made change in file pgstatmonitor.go located at agent/agents/postgres/pgstatmonitor/pgstatmonitor.go * made change in file ports_registry_test.go located at agent/agents/supervisor/ports_registry_test.go * made change in file victoriametrics.go located at managed/services/victoriametrics/victoriametrics.go * made change in file readyz_test.go located at api-tests/server/readyz_test.go * made change in file version_test.go located at api-tests/server/version_test.go * made change in file client.go located at managed/utils/platform/client.go * made change in file auth_server_test.go located at managed/services/grafana/auth_server_test.go * made change in file auth_server_test.go located at managed/services/grafana/auth_server_test.go * made change in file alertmanager.go located at managed/services/alertmanager/alertmanager.go * made change in file inventory_metrics_test.go located at managed/services/inventory/inventory_metrics_test.go * made change in file client.go located at managed/services/grafana/client.go * made change in file connection_checker.go located at agent/connectionchecker/connection_checker.go * made change in file vmalert.go located at managed/services/vmalert/vmalert.go * made change in file vmalert.go located at managed/services/vmalert/vmalert.go * made change in file metrics.go located at qan-api2/models/metrics.go * changed database.go located at managed/services/dbaas/kubernetes/client/database/ * changed database.go located at managed/services/dbaas/kubernetes/client/database/ * removed commented errcheck linyter * changes after make format * made changes in managed/services/dbaas/kubernetes/client/client.go * made changes in anaged/services/management/dbaas/components_service.go * made changes in managed/services/management/dbaas/version_service_client.go * mae\ke format changes done --------- Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com> Co-authored-by: Artem Gavrilov <[email protected]> commit 29fbba7 Author: Alex Tymchuk <[email protected]> Date: Thu Sep 28 20:32:30 2023 +0300 PMM-12547 Revert PMM-11670 Set the cluster label if empty (#2508) * Revert "PMM-11670 Set the cluster label if empty (#2459)" This reverts commit 3c58ed9. * PMM-12547 use a different IP * PMM-12547 fix the debug command in actions commit 9d919df Author: Talha Bin Rizwan <[email protected]> Date: Wed Sep 27 21:51:02 2023 +0500 PMM-7 Fix Clickhouse repository. (#2506)

* PMM-12429 mockery use configuration file * PMM-12429 fix apiKeyProvider interface * PMM-12429 update Makefile to use mockery * PMM-12429 fix path to .mockery.yaml * PMM-12429 use modern syntax for camelCase mockery * PMM-12429 install mockery prior to using * PMM-12429 fix the mockery binary path * PMM-12429 do not output the version * PMM-12429 clean up Makefiles and format

* PMM-12557 Automate PMM3 builds * Bump eslint from 8.52.0 to 8.53.0 in /cli-tests (#2596) Bumps [eslint](https://github.com/eslint/eslint) from 8.52.0 to 8.53.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.52.0...v8.53.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/sys from 0.13.0 to 0.14.0 (#2594) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.13.0 to 0.14.0. - [Commits](golang/sys@v0.13.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiří Čtvrtka <[email protected]> * Bump golang.org/x/text from 0.13.0 to 0.14.0 (#2593) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.13.0 to 0.14.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.13.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @typescript-eslint/eslint-plugin from 6.9.0 to 6.10.0 in /cli-tests (#2600) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.9.0 to 6.10.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.10.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @typescript-eslint/parser from 6.9.0 to 6.10.0 in /cli-tests (#2601) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.9.0 to 6.10.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.10.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * PMM-12670 Remove old clickhouse packages during upgrade. * PMM-12527 - CI didn't trigger after PR merge if auto-merge was enabled with github token * PMM-12527 CI didn't trigger after PR merge if auto-merge was enabled with github token * PMM-12527 CI didn't trigger after PR merge if auto-merge was enabled with github token * PMM-12527 CI didn't trigger after PR merge if auto-merge was enabled with github token revert changes * PMM-7 Fix compatibility service tests (#2608) * PMM-7 Fix compatibility service tests * PMM-7 fix postgresql version test. --------- Co-authored-by: Nurlan Moldomurov <[email protected]> * PMM-12527 CI didn't trigger after PR merge if auto-merge was enabled with github token re-try one more time with different repo config * PMM-12557 Automate PMM3 builds * PMM-7 PMM v3 devcontainer (Restored PR) (#2618) * PMM-7 Build devcontainer for PMM v3 * PMM-7 Fix * PMM-7 PMM v3 devcontainer (Restored PR) (#2618) * PMM-7 Build devcontainer for PMM v3 * PMM-7 Fix * PMM-7 PMM v3 devcontainer (Restored PR) (#2618) * PMM-7 Build devcontainer for PMM v3 * PMM-7 Fix * PMM-12557 Automate PMM3 builds - update api-tests * PMM-12557 Automate PMM3 builds - update changes * PMM-12557 Automate PMM3 builds - update changes * Update api-tests/README.md * Update api-tests/helpers.go * Update managed/.gitignore --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiří Čtvrtka <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]> Co-authored-by: Aleksandar Yanakiev <[email protected]> Co-authored-by: Artem Gavrilov <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]>

# Conflicts: # api/managementpb/dbaas/components.pb.go # api/managementpb/dbaas/db_clusters.pb.go # api/managementpb/dbaas/dbaas.pb.go # api/managementpb/dbaas/kubernetes.pb.go # api/managementpb/dbaas/logs.pb.go # api/managementpb/dbaas/psmdb_clusters.pb.go # api/managementpb/dbaas/pxc_clusters.pb.go # api/managementpb/dbaas/templates.pb.go # api/managementpb/ia/alerts.pb.go # api/managementpb/ia/channels.pb.go # api/managementpb/ia/rules.pb.go # api/managementpb/ia/status.pb.go # api/serverpb/json/client/server/test_email_alerting_settings_responses.go # api/serverpb/json/serverpb.json # api/swagger/swagger-dev.json # api/swagger/swagger.json # descriptor.bin # docker-compose.yml # managed/models/database.go # managed/services/management/node.go

) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.36.0 to 2.37.1. - [Release notes](https://github.com/vektra/mockery/releases) - [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md) - [Commits](vektra/mockery@v2.36.0...v2.37.1) --- updated-dependencies: - dependency-name: github.com/vektra/mockery/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Demidoff <[email protected]>

) * Bump github.com/vektra/mockery/v2 from 2.36.0 to 2.38.0 in /tools Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.36.0 to 2.38.0. - [Release notes](https://github.com/vektra/mockery/releases) - [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md) - [Commits](vektra/mockery@v2.36.0...v2.38.0) --- updated-dependencies: - dependency-name: github.com/vektra/mockery/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore: regenerate proto files and mocks --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Demidoff <[email protected]>

* PMM-12529 run pmm-agent as non-root * PMM-12529 update the spec and package files to leverage user pmm * PMM-12529 fix the changelog * PMM-12529 see if disabling parallel fixes the tests * PMM-12529 leave a todo for re-enabling parallel runs * PMM-12529 do not create pmm-agent user * PMM-12529 add PostgreSQL to deb description * PMM-12529 restore some changes * PMM-12529 provide a playbook to install pmm-client * PMM-12529 fix a typo * PMM-12529 Move the agent role to build roles * PMM-12529 fix the tax syntax * PMM-12529 create an empty dir * PMM-12529 pass the client to PMM Server docker * PMM-12529 fix the tabulation * PMM-12529 remove v2 from paths * PMM-12529 update the agent installation path

* PMM-12693 Run grafana as non-root * PMM-12693 rebuild grafana with new perms * PMM-12693 remove sqlite migration * PMM-12693 remove sqlite migration * PMM-12693 revert some spec changes * PMM-12693 check grafana logs * PMM-12693 remove grafana-db-migrator * PMM-12693 create grafana dir explicitly * PMM-12693 fix with_items syntax * PMM-12693 take ownership of /etc/grafana * PMM-12693 try other options for /etc/grafana * PMM-12693 try different permissions on /etc/grafana * PMM-12693 remove grafana user * PMM-12693 remove grafana user * PMM-12693 set dir permissions for grafana-dashboards * PMM-12693 do not install packages twice * PMM-12693 remove CentOS 7 tasks * PMM-12693 move grafana bootstrap to an earlier time * PMM-12693 remove more CentOS 7 tasks * PMM-12693 move clickhouse install back * PMM-12693 do not upgrade sqlite * PMM-12693 clean up the dashboards playbook * PMM-12693 clean up the update playbook * Update build/packages/rpm/server/SPECS/percona-dashboards.spec Co-authored-by: Nurlan Moldomurov <[email protected]> * PMM-12693 follow up on review * PMM-12693 move the version copying out of dashboards_update * PMM-12693 trigger the build * PMM-12693 hackily start pmm-agent * PMM-12693 check the status of services * PMM-7 wait for container to get healthy * PMM-7 debug: output grafana logs * PMM-7 debug the ownership of /etc/grafana/grafana.ini * PMM-7 change ownership of /etc/grafana to pmm * PMM-7 change ownership of /srv/grafana to pmm * PMM-7 cleanup the workflow --------- Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-12284 Remove alertmanager * PMM-12284 Remove alertmanager URL from settings * PMM-12284 Fix api tests

* PMM-7 cleanup docker-compose.yml * PMM-7 enable agent autostart after build * PMM-12693 change ownership on /srv/grafana * PMM-12693 clean up the workflow * PMM-7 revert the change to post-build

# Conflicts: # agent/config/config.go # agent/config/config_test.go # go.sum # update/ansible/playbook/tasks/roles/initialization/tasks/main.yml

* PMM-12692 modify the entrypoint * PMM-12692 run postgres as pmm user * PMM-12692 ingore errors when stopping pmm-managed * PMM-12692 remove supervisorctl_path * PMM-12692 fix ownership on /srv/logs * PMM-7 add more debug msgs * PMM-7 try postgres user * PMM-7 try using the shell for ther sake of stderr output * PMM-12692 create postgres role * PMM-12692 remove grafana-db-migrator spec * PMM-12692 create a user with a script * PMM-12692 shorten /var/run to just /run * PMM-12692 comment out redundant steps * PMM-12692 optimize a few grafana settings * PMM-12692 do not create postgres user * PMM-12692 update the entrypoint * PMM-12692 fix a typo * PMM-12692 clean up post-build * PMM-12692 add pg_stat_statements extension * PMM-12692 add the migration doc * PMM-12692 mark the migration doc as darft * PMM-12692 update the migration doc * PMM-12692 follow up on review * PMM-12692 follow up on review

* PMM-8306 fix SSH Key * PMM-8306 fix SSH Key

* PMM-8471 run nginx as non-root * PMM-8471 fix the tests * PMM-8471 fix supervisord tests * PMM-8471 fix an unvoluntary typo ) * PMM-8471 run nginx on behalf of pmm user * PMM-8471 do not create nginx user * PMM-8471 update nginx.conf to run nginx on behalf of pmm user * PMM-8471 revert some changes related to the client * PMM-8471 fix http ports in docker-compose * PMM-8471 skip the update test

* transferred API changes from main RelNotes * Update docs/release-notes/3.0.0.Beta.md Co-authored-by: Alex Demidoff <[email protected]> --------- Co-authored-by: Alex Demidoff <[email protected]>

* PMM-13485 Fix ovf pipeline. * Update build/Makefile Co-authored-by: Alex Demidoff <[email protected]> * Update build/Makefile Co-authored-by: Alex Demidoff <[email protected]> * PMM-13485 Fix ovf pipeline. --------- Co-authored-by: Alex Demidoff <[email protected]>

* PMM-12641 update ansible configs * PMM-12641 remove redundant playbooks/tasks * PMM-12641 optimize the structure of playbooks, make update.yml redundant * PMM-12641 trigger the build * PMM-12641 fix the playbook name * PMM-12641 pre-pull rpmbuild:3 to the agent * PMM-12641 remove randomwait=1 for faster builds * PMM-12641 put back the init.yml playbook * PMM-12641 remove the unused nginx repository * PMM-12641 fix pid location for nginx * PMM-12641 remove a redundant repository * PMM-12641 fix the startup logic * PMM-12641 simplify version detection * PMM-12641 fix an error * PMM-12641 fix the client user name * PMM-12641 fix nginx being unable to start * PMM-12641 install Goreleaser on the agent * PMM-12641 cleanup RH7 tweaks * PMM-12641 stop Grafana before reinstalling the plugins * PMM-12641 move nginx's pid to /tmp * PMM-12641 stop grafana before provisioning plugins * PMM-12641 remove redundant pkg provisioning * PMM-12641 revert moving nginx's pid * PMM-12641 remove redundant config reread * PMM-12641 do not start grafana initially * PMM-12641 cleanup the comments * PMM-12641 move post-build.yml to the same playbook * PMM-12641 cleanup the docs * PMM-12641 remove space around block: * PMM-12641 remove another redundant playbook * PMM-12641 add an ssh key for a team member * PMM-12641 remove redundant build script * PMM-12641 fix the padding * PMM-12641 don't add ssh keys to the agent * Apply suggestions from code review Co-authored-by: Catalina A <[email protected]> * PMM-12641 Refine the task descriptions * PMM-12641 Refine the task descriptions * Update build/docker/client/Dockerfile Co-authored-by: Nurlan Moldomurov <[email protected]> * PMM-12641 Remove the encryption key * PMM-12641 Fix duplicate psycopg2 installation * PMM-12641 move psycopg2 installation to pg playbook --------- Co-authored-by: Catalina A <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-13416 Fix enum flags in pmm-admin. * PMM-13416 Fix tests. * PMM-13416 pmm-agent metrics mode. * PMM-13416 fix linters. * PMM-13416 fix linters. * PMM-7 fix log level value on Server side. * PMM-13416 fix log level value on API. * PMM-13416 Regenerate. * PMM-13416 Fix license. * PMM-13416 Fix license. * PMM-13416 Fix linters. * PMM-13416 Fix imports linter.

* PMM-13315 Remove comment about SA max length. * PMM-13315 Long postfix for tests. * trigger * Revert "PMM-13315 Remove comment about SA max length." This reverts commit d812c2a. * PMM-13315 Long SA names hashing. * PMM-13315 Lint. * PMM-11315 Changes, refactor. * PMM-13315 Format. * PMM-13315 Remove forgotten prints. * PMM-13315 Remove another print. * PMM-13315 Fix problem with big orgIDs. * PMM-13315 Move SanitizeSAName to global utils. * PMM-13315 Headers. * PMM-13315 Licence year. * PMM-13315 Lint.

* PMM-12820 Remove "postgres" from excluded DBs. * PMM-12820 Fix tests.

* PMM-13373 Different max query length for MongoDB. * PMM-13373 Fix. * PMM-13373 Required changes.

* PMM-13413 Use the envvar to disable pg telemetry reporting * PMM-13413 Supress parser warnings on telemetry envvars

* PMM-13057 Fix imports. * WIP on PMM-13057-new-telemetry * PMM-13057 Changes. * PMM-13057 Tidy. * PMM-13057 Tidy. * PMM-13057 Remove print. * PMM-13057 Fix test. * PMM-13057 Refactor. * PMM-13057 Format. * PMM-13057 Fix for UUIDs format. * PMM-13057 Add product family field. * PMM-13057 Requested renaming. * PMM-13057 Fix for changes. --------- Co-authored-by: Nurlan Moldomurov <[email protected]> Co-authored-by: Alex Demidoff <[email protected]>

Co-authored-by: Alex Demidoff <[email protected]>

* PMM-12155 Use new option name for node_exporter Since the new version of exporter-toolkit used in the node exporter the new option `--web.config.file` should be used instead to pass the TLS configuration. * PMM-12155 Improve formatting Improve variable declaration formatting. * PMM-12155 Add unit test for new option Add unit test to pass the new option to the exporter and add some slight fixes to the formatting and styling. * PMM-12155 Styling fixes * PMM-12155 Styling fixes * PMM-12155 refactoring. * PMM-12155 refactoring. * PMM-12155 fix linter. * PMM-12155 fix build. * PMM-12155 fix linter. * Update version/features.go --------- Co-authored-by: Roman Novikov <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-13399 include nomad into pmm-client. * PMM-13399 include nomad into pmm-client. * PMM-13399 include nomad into pmm-client. * PMM-13399 install tree. * PMM-13399 install deps. * PMM-13399 install deps. * PMM-13399 trying to fix build. * PMM-13399 copy binary. * PMM-13399 copy nomad binary. * PMM-13399 add nomad to pmm-agent config. * PMM-13399 add nomad to pmm-agent config. * PMM-13399 add nomad data dir to pmm-agent config. * PMM-13399 add nomad data dir to tests and flags. * PMM-13399 Fix tests. * PMM-13399 Apply suggestions from code review Co-authored-by: Alex Demidoff <[email protected]> * PMM-13399 Address review comments. --------- Co-authored-by: Alex Demidoff <[email protected]>

* PMM-12013 run RDS exporter on client instances. * PMM-12013 go mod tidy. * PMM-12013 Fix tests. * PMM-12013 Fix tests. * PMM-12013 Fix imports. * PMM-12013 Fix conflicts. * PMM-13416 regenerate.

* PMM-13392 fix agent status prefix for json * PMM-13392 fix status_test * PMM-13392 regenrate the swagger spec

* PMM-13082 Backward-compatibility with PMM 2 Client. * PMM-13082 Strip prefixes, revert changes to collector.proto * PMM-13082 remove unused proto imports * PMM-13082 renumber agent_status.proto fields * PMM-13082 fix the lint rules for pb/agent.proto pkg * PMM-13082 fix the proto field numbers for AGENT_TYPE * PMM-13082 fix the function comment * PMM-13082 revert stripping the IDs * PMM-13082 revert the text fix * PMM-13082 revert slowlog_test fix * PMM-13082 re-generate the code * PMM-13082 fix agent_type in slowlog_test payload * PMM-13082 leave a TODO comment --------- Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-13540 Fix pmm client v3 build for nomad.

* PMM-7 Run supervisor as pmm during build * PMM-7 Fix label assignment syntax warning * PMM-7 Clean yum cache as well

percona-robot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:inamedparam is unused for linter "inamedparam" (nolintlint)

pmm/agent/client/deps.go

Line 53 in 417d80b

SetState(*agentv1.SetStateRequest) //nolint:inamedparam

🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:typecheck is unused for linter "typecheck" (nolintlint)

pmm/managed/services/inventory/grpc/agents_server.go

Line 214 in 417d80b

agentID := req.GetAgentId() //nolint:typecheck

percona-robot · 2024-11-18T11:57:29Z

admin/commands/status.go

@@ -46,7 +46,7 @@ PMM Client:
 	pmm-admin version: {{ .PMMVersion }}
 	pmm-agent version: {{ .PMMAgentStatus.AgentVersion }}
 Agents:
-{{ range .PMMAgentStatus.Agents }}	{{ .AgentID }} {{ .AgentType | $.HumanReadableAgentType }} {{ .Status | $.NiceAgentStatus }} {{ .Port }}
+{{ range .PMMAgentStatus.Agents }}	{{ .AgentID }} {{ printf "%-29s" (.AgentType | $.HumanReadableAgentType) }} {{ printf "%-15s" (.Status | $.NiceAgentStatus) }} {{ .Port }}


🚫 [golangci] _{reported by reviewdog 🐶}
the line is 176 characters long, which exceeds the maximum of 170 characters. (lll)

percona-robot · 2024-11-18T11:57:29Z

api/inventory/v1/agents.go

@@ -13,7 +12,8 @@
 //
 // You should have received a copy of the GNU Affero General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
-package inventorypb
+
+package inventoryv1


🚫 [golangci] _{reported by reviewdog 🐶}
package-comments: should have a package comment (revive)

percona-robot · 2024-11-18T11:57:29Z

api/inventory/v1/log_levels.go

+	"github.com/percona/pmm/utils/enums"
+)
+
+func LogLevelAPIValue(l *string) LogLevel {


🚫 [golangci] _{reported by reviewdog 🐶}
exported: exported function LogLevelAPIValue should have comment or be unexported (revive)

percona-robot · 2024-11-18T11:57:30Z

managed/services/server/server.go

 		t := v.Latest.BuildTime.UTC().Truncate(24 * time.Hour) // return only date
 		res.Latest.Timestamp = timestamppb.New(t)
 	}

 	return res, nil
 }

+// ListChangeLogs lists PMM versions between currently installed version and the latest one.
+func (s *Server) ListChangeLogs(ctx context.Context, req *serverv1.ListChangeLogsRequest) (*serverv1.ListChangeLogsResponse, error) {


🚫 [golangci] _{reported by reviewdog 🐶}
unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive)

percona-robot · 2024-11-18T11:57:30Z

managed/services/management/node.go

 		}
 	}

 	return res, nil
 }
+
+// Unregister do unregistration of the node.


🚫 [golangci] _{reported by reviewdog 🐶}
exported: comment on exported method ManagementService.UnregisterNode should be of the form "UnregisterNode ..." (revive)

percona-robot · 2024-11-18T11:57:32Z

api-tests/alerting/alerting_test.go

+
+	expectedYAML, err := alert.ToYAML([]alert.Template{expectedTemplate})
+	require.NoError(t, err)
+	assert.Equal(t, expectedYAML, tmpl.Yaml)


🚫 [golangci] _{reported by reviewdog 🐶}
encoded-compare: use assert.YAMLEq (testifylint)

percona-robot · 2024-11-18T11:57:32Z

api-tests/inventory/agents_mysqld_exporter_test.go

 		})
-		assert.Greater(t, mySqldExporter.TableCount, int32(0))
+		assert.Greater(t, mySqldExporter.MysqldExporter.TableCount, int32(0))


🚫 [golangci] _{reported by reviewdog 🐶}
negative-positive: use assert.Positive (testifylint)

percona-robot · 2024-11-18T11:57:32Z

agent/agents/cache/cache_test.go


 		_, err = New(struct{}{}, time.Second*100, 100, logrus.WithField("test", t.Name()))
-		assert.NotNil(t, err)
+		assert.Error(t, err) //nolint:testifylint


🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:testifylint is unused for linter "testifylint" (nolintlint)

percona-robot · 2024-11-18T11:57:33Z

managed/services/telemetry/uievents/uievents.go

@@ -96,11 +96,11 @@ func (s *Service) ScheduleCleanup(ctx context.Context) {
 }

 // FetchMetrics fetches metrics for the service based on the provided context and telemetry configuration.
-func (s *Service) FetchMetrics(_ context.Context, _ telemetry.Config) ([]*pmmv1.ServerMetric_Metric, error) { //nolint:unparam
+func (s *Service) FetchMetrics(_ context.Context, _ telemetry.Config) ([]*telemetryv1.GenericReport_Metric, error) { //nolint:unparam


🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:unparam is unused for linter "unparam" (nolintlint)

percona-robot · 2024-11-18T11:57:33Z

managed/services/agents/channel/channel.go

 	Error   error
 }

 type Stream interface { //nolint:revive
-	Send(*agentpb.ServerMessage) error
-	Recv() (*agentpb.AgentMessage, error)
+	Send(*agentv1.ServerMessage) error //nolint:inamedparam


🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:inamedparam is unused for linter "inamedparam" (nolintlint)

* improve error handling for empty version list * drop unneeded check * use debug messages and fix formatting * Allow nil in latest tests There is a possibility of nil (when we don't have any tag available). This updates the test to allow such cases and only check if latest is not nil * support staging and prod version lists * update version URL * trigger rebuild --------- Co-authored-by: Alex Demidoff <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]>

percona-robot · 2024-11-18T14:03:58Z

managed/services/server/server.go

+	newImage := req.GetNewImage()
+	if newImage == "" {
+		_, latest, err := s.updater.latest(ctx)
+		if err != nil {


🚫 [golangci] _{reported by reviewdog 🐶}
ifElseChain: rewrite if-else to switch statement (gocritic)

percona-robot · 2024-11-18T14:03:58Z

managed/services/server/updater.go

+	if len(strings.Split(name, "/")) < 3 {
+		name = "docker.io/" + name
+	}
+	file, err := os.ReadFile(filename)


🚫 [golangci] _{reported by reviewdog 🐶}
G304: Potential file inclusion via variable (gosec)

percona-robot · 2024-11-18T14:03:58Z

managed/services/server/updater.go

+			lines[i] = fmt.Sprintf("PMM_IMAGE=%s", name)
+		}
+	}
+	err = os.WriteFile(filename, []byte(strings.Join(lines, "\n")), 0o644)


🚫 [golangci] _{reported by reviewdog 🐶}
G306: Expect WriteFile permissions to be 0600 or less (gosec)

percona-robot · 2024-11-18T14:03:58Z

managed/services/server/updater_test.go

+PMM_SERVER_UPDATE_VERSION=docker.io/perconalab/pmm-server:3-dev-container
+PMM_IMAGE=docker.io/perconalab/pmm-server:3-dev-latest
+PMM_DISTRIBUTION_METHOD=ami`
+		err := os.WriteFile(tmpFile, []byte(content), 0o644)


🚫 [golangci] _{reported by reviewdog 🐶}
G306: Expect WriteFile permissions to be 0600 or less (gosec)

percona-robot · 2024-11-18T14:03:59Z

managed/services/server/updater_test.go

+
+		err = u.updatePodmanEnvironmentVariables(tmpFile, "perconalab/pmm-server:3-dev-container")
+		require.NoError(t, err)
+		newContent, err := os.ReadFile(tmpFile)


🚫 [golangci] _{reported by reviewdog 🐶}
G304: Potential file inclusion via variable (gosec)

percona-robot · 2024-11-18T14:03:59Z

managed/services/server/server.go

+		} else if latest == nil {
+			s.l.Info("No new version to update to.")
+			return nil, status.Error(codes.FailedPrecondition, "No new version to update to.")
+		} else {


🚫 [golangci] _{reported by reviewdog 🐶}
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)

percona-robot · 2024-11-18T14:03:59Z

managed/services/server/updater.go

+
+	if len(metadataResponse.Versions) != 0 {
+		up.l.Debugf("Found %d versions", len(metadataResponse.Versions))
+		updates, next := up.next(*up.currentVersion(), metadataResponse.Versions)


🚫 [golangci] _{reported by reviewdog 🐶}
Function next should pass the context parameter (contextcheck)

percona-robot · 2024-11-18T14:03:59Z

managed/services/server/server.go

+		if req.SshKey != nil {
+			if err = s.writeSSHKey(pointer.GetString(req.SshKey)); err != nil {
+				s.l.Error(errors.WithStack(err))
+				return status.Errorf(codes.Internal, err.Error())


🚫 [golangci] _{reported by reviewdog 🐶}
printf: non-constant format string in call to google.golang.org/grpc/status.Errorf (govet)

percona-robot · 2024-11-18T14:03:59Z

agent/client/deps.go

-	SetState(*agentpb.SetStateRequest)
+	Changes() <-chan *agentv1.StateChangedRequest
+	QANRequests() <-chan *agentv1.QANCollectRequest
+	SetState(*agentv1.SetStateRequest) //nolint:inamedparam


🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:inamedparam is unused for linter "inamedparam" (nolintlint)

percona-robot · 2024-11-18T14:03:59Z

managed/services/inventory/grpc/agents_server.go

+
+// ChangeAgent allows to change some Agent attributes.
+func (s *agentsServer) ChangeAgent(ctx context.Context, req *inventoryv1.ChangeAgentRequest) (*inventoryv1.ChangeAgentResponse, error) {
+	agentID := req.GetAgentId() //nolint:typecheck


🚫 [golangci] _{reported by reviewdog 🐶}
directive //nolint:typecheck is unused for linter "typecheck" (nolintlint)

* PMM-13553 Revert update kong from 1.3.0 to 1.4.0 (#3282)" * PMM-13553 Fix grafana restart * PMM-13553 Wait until grafana has started * PMM-13553 Wait until grafana stops * Update main.yml

percona-robot · 2024-11-19T23:47:27Z

managed/services/alerting/service.go

-			TotalPages: 1,
-		},
+		Templates:  make([]*alerting.Template, 0, len(templates)),
+		TotalItems: int32(len(templates)),


🚫 [golangci] _{reported by reviewdog 🐶}
G115: integer overflow conversion int -> int32 (gosec)

percona-robot · 2024-11-19T23:47:27Z

managed/services/alerting/service.go

 	}

 	if pageSize > 0 {
-		res.Totals.TotalPages = int32(len(templates) / pageSize)
+		res.TotalPages = int32(len(templates) / pageSize)


🚫 [golangci] _{reported by reviewdog 🐶}
G115: integer overflow conversion int -> int32 (gosec)

gen1us2k and others added 3 commits September 28, 2023 22:50

EVEREST-287 Drop DBaaS (#2510)

bf2a099

Merge branch 'main' into v3

e945349

# Conflicts: # docs/api/dbaas/dbaas.md # docs/dbaas/olm.md # go.mod # managed/models/database.go

BupycHuk and others added 26 commits October 11, 2023 13:49

Merge branch 'main' into v3

dfdbc87

# Conflicts: # go.mod # go.sum

PMM-7 DBaaS leftovers to remove. (#2539)

37715cf

Merge branch 'main' into v3

106d813

Merge branch 'main' into v3

e2d491d

PMM-7 Merge PMM 2 changes into v3 branch.

3fad605

PMM-7 Fix tests. (#2628)

d49a506

Merge branch 'main' into v3

5aa6e6b

Merge branch 'main' into v3

2b250e6

PMM-12284 Remove Alertmanager (#2614)

b1a4941

* PMM-12284 Remove alertmanager * PMM-12284 Remove alertmanager URL from settings * PMM-12284 Fix api tests

PMM-7 cleanup docker-compose.yml for v3 (#2667)

caafee9

* PMM-7 cleanup docker-compose.yml * PMM-7 enable agent autostart after build * PMM-12693 change ownership on /srv/grafana * PMM-12693 clean up the workflow * PMM-7 revert the change to post-build

Merge branch 'main' into v3

f42b62d

# Conflicts: # agent/config/config.go # agent/config/config_test.go # go.sum # update/ansible/playbook/tasks/roles/initialization/tasks/main.yml

PMM-7 go mod tidy

0295da7

PMM-8306 fix ssh key bug (#2686)

0a49079

* PMM-8306 fix SSH Key * PMM-8306 fix SSH Key

BupycHuk and others added 23 commits November 7, 2024 19:02

PMM-13502 Fix for pmm-admin remove service. (#3287)

c2b8138

transferred API changes from main RelNotes (#3283)

caa4626

* transferred API changes from main RelNotes * Update docs/release-notes/3.0.0.Beta.md Co-authored-by: Alex Demidoff <[email protected]> --------- Co-authored-by: Alex Demidoff <[email protected]>

PMM-12820 Remove "postgres" from excluded DBs. (#3268)

da4f7fb

* PMM-12820 Remove "postgres" from excluded DBs. * PMM-12820 Fix tests.

PMM-13373 Different QAN max query length for MongoDB. (#3273)

1f96828

* PMM-13373 Different max query length for MongoDB. * PMM-13373 Fix. * PMM-13373 Required changes.

PMM-13413 Do not run pillars telemetry (#3264)

11e5142

* PMM-13413 Use the envvar to disable pg telemetry reporting * PMM-13413 Supress parser warnings on telemetry envvars

moved under API (#3292)

7974dba

Co-authored-by: Alex Demidoff <[email protected]>

PMM-12013 rds exporter (#3057)

8cb6278

* PMM-12013 run RDS exporter on client instances. * PMM-12013 go mod tidy. * PMM-12013 Fix tests. * PMM-12013 Fix tests. * PMM-12013 Fix imports. * PMM-12013 Fix conflicts. * PMM-13416 regenerate.

PMM-12013 Fix scrapeconfig generation for rds exporter. (#3293)

9fcf353

PMM-13392 Strip agent status prefix in json (#3276)

b70db18

* PMM-13392 fix agent status prefix for json * PMM-13392 fix status_test * PMM-13392 regenrate the swagger spec

PMM-13399 include nomad into pmm client.

7852170

PMM-13540 Fix pmm client v3 build for nomad. (#3298)

9369be0

* PMM-13540 Fix pmm client v3 build for nomad.

PMM-7 Run supervisor as pmm during build (#3309)

176a136

* PMM-7 Run supervisor as pmm during build * PMM-7 Fix label assignment syntax warning * PMM-7 Clean yum cache as well

Merge branch 'main' into v3

d5db2f6

Merge branch 'main' into v3

4ee890d

Merge remote-tracking branch 'origin/main' into v3

417d80b

percona-robot reviewed Nov 18, 2024

View reviewed changes

ademidoff added 2 commits November 19, 2024 10:08

PMM-7 Fix grafana start and stop (#3320)

45998f9

PMM-13553 Revert the upgrade of kong (#3319)

82310f6

* PMM-13553 Revert update kong from 1.3.0 to 1.4.0 (#3282)" * PMM-13553 Fix grafana restart * PMM-13553 Wait until grafana has started * PMM-13553 Wait until grafana stops * Update main.yml

ademidoff force-pushed the v3 branch from fb01dfa to 82310f6 Compare November 19, 2024 23:41

percona-robot reviewed Nov 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V3 - DO NOT MERGE #2525

V3 - DO NOT MERGE #2525

BupycHuk commented Oct 7, 2023 •

edited by ademidoff

Loading

codecov bot commented Oct 7, 2023 •

edited

Loading

percona-robot left a comment

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 18, 2024

percona-robot Nov 19, 2024

percona-robot Nov 19, 2024

V3 - DO NOT MERGE #2525

Are you sure you want to change the base?

V3 - DO NOT MERGE #2525

Conversation

BupycHuk commented Oct 7, 2023 • edited by ademidoff Loading

codecov bot commented Oct 7, 2023 • edited Loading

Codecov Report

percona-robot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BupycHuk commented Oct 7, 2023 •

edited by ademidoff

Loading

codecov bot commented Oct 7, 2023 •

edited

Loading