Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addDeviceToProduct doesn't appear to reject on error? #75

Open
dmiddlecamp opened this issue Oct 25, 2017 · 1 comment
Open

addDeviceToProduct doesn't appear to reject on error? #75

dmiddlecamp opened this issue Oct 25, 2017 · 1 comment

Comments

@dmiddlecamp
Copy link
Contributor

observed behavior: added a device of non-matching platform to a product, no error, resolves normally.

expected behavior: addDeviceToProduct rejects with an error, since the API request did not succeed

@monkbroc
Copy link
Member

Hum, since that API endpoint accepts a list of devices to add to a product and it returns 3 arrays, which ones were added, which ones were the wrong platform and which ones were owned by someone else, I'm not sure it make sense to reject. This is better handled by the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants