Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFlowGraphModel::setNodeData ignores most input #434

Open
emilfors opened this issue Jul 31, 2024 · 0 comments
Open

DataFlowGraphModel::setNodeData ignores most input #434

emilfors opened this issue Jul 31, 2024 · 0 comments

Comments

@emilfors
Copy link

The DataFlowGraphModel::setNodeData function silently ignores anything except node position and size, and the nodeData function returns the model data for most node roles (except size and position). This means you can't individually set any of the other roles for a specific node, despite the setNodeData documentation's claim that you can use it to do precisely that.

Is this by design? Is the intention that if we do need this functionality, we extend the DataFlowGraphModel class and override the setNodeData and nodeData functions? Or is the class simply not quite finished yet.

Also, internally the DataFlowGraphModel keeps track of node geometry through an internal map from node ids to geometries. Why is there no concept of individual nodes anymore? Is it really the intention that each individual node role is stored in a separate map in the graph model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant