Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential codebase merge #5

Open
brandond opened this issue Aug 3, 2016 · 1 comment
Open

Potential codebase merge #5

brandond opened this issue Aug 3, 2016 · 1 comment

Comments

@brandond
Copy link

brandond commented Aug 3, 2016

Hi - I am just getting around to publishing a module I put together that does Negotiate auth using the Win32 SSPI interface, rather than the platform-agnostic GSSAPI that your module uses. Would you be receptive to a PR to merge the two, or should I rename my module and keep the code separate?

https://github.com/brandond/requests-negotiate

@alexdutton
Copy link
Contributor

I'm intrigued, yes 😄.

I think it would be good to have it implemented with a new __init__ param to specify which implementation to use, with the default being to try gssapi and then the Win32 interface. Though it should still complain about gssapi being missing if neither is present, to preserve existing behaviour. Sound good?

Also worth noting that I've just created a pull request to fix an rDNS-related bug, which you may want to base off, as I hope to merge it soon after a bit more testing.

And sorry for not noticing this for a couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants