Implementation for Analog to Digital converter #281
+132
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrlmanoharreddy
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Your implementation is super solid, but to enhance code robustness, please add try-catch blocks in the readValue() method to catch any runtime exceptions and log them appropriately. This will help with error handling and improve reliability. Additionally, please include comments explaining the reason behind operations such as cs.low() or clk.high() to make the code clearer for future maintainers. Once these adjustments are made, the code will be more comprehensive and easier to maintain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278
Created ADCConverterHelper.java, and ADCConverterController.java in order to have functionality for ADC0834 and other Analog to Digital devices.
ADC implementation was needed in order to implement a thermistor and any other analog devices. The Raspberry pi does not have any analog pins so this ADC bridge is needed. The Raspberry Pi is communicating with the ADC and not thermistor, as the thermistor is communicating with the ADC.
The helper class implements the basic input and output that the ADC takes and sends. The controller is the way we can see the output that the ADC sends. Then the Application.yml has been updated to handle the many communication protocols that the ADC has.