Add ContinuousIntegrationBuild to DotNetCorePackSettings

[RehanSaeed]

ContinuousIntegrationBuild is Documented in https://devblogs.microsoft.com/dotnet/producing-packages-with-source-link/#deterministic-builds and is important for creating deterministic builds on different machines and operating systems. Suggested API:

new DotNetCorePackSettings()
{
    ContinuousIntegrationBuild = true
};

[augustoproiete]

LGTM

Current workaround is to use WithProperty:

DotNetCoreBuild("./SolutionName.sln", new DotNetCoreBuildSettings
{
    // ...

    MSBuildSettings = new DotNetCoreMSBuildSettings()
            .WithProperty("ContinuousIntegrationBuild", BuildSystem.IsLocalBuild ? "false" : "true")
});

[RehanSaeed]

Can we turn this into an issue?

[devlead]

Done
#3447

[augustoproiete]

@RehanSaeed I noticed you suggested adding this argument to DotNetCorePackSettings and this parameter is an MSBuild property that needs to be present during build (not pack) e.g. via DotNetCoreBuild unless, of course, when DotNetCorePack causes a build to be triggered first, so in both cases, it seems DotNetCoreMSBuildSettings seems to be the appropriate place for adding this property.

Thoughts?

[RehanSaeed]

My understanding is that it changes file paths in the nupkg, so you need to enable it in pack. I'm not sure about build. Happy to find a definitive answer.

But yes your suggestion makes total sense.

[augustoproiete]

@RehanSaeed PR open #3460