Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thai translation for session expired message #1557

Open
3 tasks done
Rkareko opened this issue Mar 16, 2022 · 4 comments · May be fixed by #1558
Open
3 tasks done

Add Thai translation for session expired message #1557

Rkareko opened this issue Mar 16, 2022 · 4 comments · May be fixed by #1558
Assignees

Comments

@Rkareko
Copy link
Contributor

Rkareko commented Mar 16, 2022

  • Update client-core version to 4.3.30-SNAPSHOT that contains the fix on Change logout message when session expired PR
  • Add the following Thai translation on Reveal
    "Your session has expired. Please log in again." = "ระยะเวลาการล็อกอินของคุณหมดแล้ว กรุณาล็อกอินเพื่อเข้าสู่ระบบอีกครั้ง"
  • Verify that the client core version upgrade does not introduce regression bugs

Testing

  1. Log into the app and ensure initial sync is complete
  2. In Keycloak admin console logout the user session
  3. Initiate sync from the hamburger menu
  4. Ensure that the app logs out the user
  5. Ensure that for the English apk the following message is displayed Your session has expired. Please log in again.
  6. Ensure that for the Thai apk the following message is displayed ระยะเวลาการล็อกอินของคุณหมดแล้ว กรุณาล็อกอินเพื่อเข้าสู่ระบบอีกครั้ง
  7. Perform regression testing of the app. This is done because the client core library version has been incremented.
@Rkareko Rkareko linked a pull request Mar 22, 2022 that will close this issue
@Rkareko Rkareko self-assigned this Mar 22, 2022
@madrinekariuki
Copy link

madrinekariuki commented Mar 23, 2022

@Rkareko
This has been tested using the shared apks :
opensrp-reveal-5.3.29-rc1-th.apk
opensrp-reveal-5.3.29-rc1-th-en.apk

followed the steps highlighted here

observations:
for this issue #1557:
-On the Thai- En apk after i disabled the user i am using test77 and from the apk i automatically got logged out with the message Your session has expired. Please log in again but we still have the account disabled message.

  • On Thai apk, the session expired message is in english.
    screenshots shared below.

For Regression test i.e no 7: this has been observed on the Thai -en apk.

  • The forms seem to have changed e.g family reg form, bednet, Blood Screening form.
  • After recording the Blood screening, its not changing and when you open the form, the details are not there
  • first name is not appearing it is showing the name as zero

screenshots attached:
Video for points 2 $ 3 shared on slack

for 1557 (transalation)
image

Regression tests:
image

@Rkareko
Copy link
Contributor Author

Rkareko commented Mar 23, 2022

@madrinekariuki cc @samkanga I'll work on the fix for this

On Thai apk, the session expired message is in english.
screenshots shared below.

@Rkareko
Copy link
Contributor Author

Rkareko commented Mar 23, 2022

For Regression test i.e no 7: this has been observed on the Thai -en apk.

The forms seem to have changed e.g family reg form, bednet, Blood Screening form.
After recording the Blood screening, its not changing and when you open the form, the details are not there
first name is not appearing it is showing the name as zero

These might be a result of the forms being changed via form config functionality.
@samkanga are there any issues with reverting the forms to the original ones found here ?

@samkanga
Copy link

@Rkareko we don't need to update them unless CHAI requests us to since we don't know if they are working on something. For now we can mainly focus on the error message and not worry about the forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants