Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App force closing when switching the child profile across registers #509

Open
2 tasks
AnnieMungai opened this issue Mar 22, 2023 · 6 comments
Open
2 tasks
Assignees
Labels

Comments

@AnnieMungai
Copy link

Kindly fill in the required fields indicated by * to give us better context, help in billing and priotizing your request

Project Name*

Malawi eregister

Description*

App force closing when navigating to the child profile opened on All clients or OPD register.

Steps to reproduce*

  1. Navigate to the ALL clients register.
  2. Tap on a child that is less than 5 years old.
  3. Once the profile is opened, tap Switch register view at the bottom of the page.
  4. Observe.
Screenrecorder-2023-03-21-15-28-04-62.mp4

Acceptance criteria*

  • When a user opens a child profile from OPD or All clients register, the child OPD profile is accessible.
  • If user taps on switch register view. They are redirected to the child's profile- child register view.

Affected OpenSRP Android client and server

  • V 0.4.7- preview

Core developers

Who were the main developers on the project before go-live?

Possible Solution(s) if possible*

  • Solution 1
  • Solution 2
  • Solution 3

Avaza project to bill*

Which project should be billed on Avaza?

When do you think you will need the request done by?*

Awaiting client go-live

Remember:

  1. To alert the team in the #opensrp-support channel.
  2. To follow up on delivery if it takes too long
@ekigamba
Copy link
Contributor

ekigamba commented Mar 23, 2023

The switch feature seems to work OK when tested with other valid child client found in the child register

This client/child has a mother who is 3 years old. The client cannot be found in the child register. I'm not sure how they got connected together but the mother is not a formal mother since they do not have a Woman Registration event and therefore is probably not a valid mother.

@AnnieMungai can you provide guidance on these features and the scope of the child registration form when connecting with a mother. I'll be testing whether this is a bug or we can connect a new child to another client, age unrestricted.

@AnnieMungai
Copy link
Author

AnnieMungai commented Mar 23, 2023

@ekigamba I have retested this with a new child registration, not sure how this child was assigned to a parent 3yrs old. I have retested this with a new child. You cannot assign someone who is not 10+ years as a caregiver. This is working as it should. With the new child, the app is not force closing.

However, when a child is assigned someone that was registered through OPD, this is force closing, and child cannot be viewed on the child register.

@AnnieMungai
Copy link
Author

Based on discussions - persons registered in OPD - even if they are under 10yrs can still be assigned to a child as a caregiver.

@ekigamba is it possible to disable the registration form on OPD - client said they will not be using that module, so registrations only happen in All clients and other registers.

@ekigamba
Copy link
Contributor

@AnnieMungai I just tested registering children with mothers enrolled in PNC, Maternity and ANC registers. The children are visible in the child register and the crash does not happen when switching from the all clients profile.

I'd say that I think this will work to reduce the LOE greatly.

However,

  • the all clients register also has an OPD registration form for any client who is above 5 years old. This is still another entry point.
  • The current OPD registered clients will not be eligible mothers with the proposed fix

@AnnieMungai
Copy link
Author

@ekigamba I am fine with this fix. We can move ahead.

@Naima-Bashir
Copy link

Naima-Bashir commented Mar 27, 2023

Hi @AnnieMungai @ekigamba , I have tested this on a Galaxy tab Active Pro.
The app force closes in a very specific scenario. Below are the replicable steps

  1. Navigate to the OPD clients
  2. Create a mother (Jane Doe) and fill in the details.
  3. Go to the all clients and create a child under 5 (Child Doe)
  4. Fill in the details and assign the mother we had created(Jane Doe) to the child (Child Doe)
  5. Tap on a child (Child Doe)
  6. Once the profile is opened, tap Switch register view at the bottom of the page.
  7. Observe how the app force closes.

This is still failing QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants