Implement AsyncOpenSearch() parameter ssl_assert_hostname
#843
Conversation
…disabling SSL hostname verification Signed-off-by: merlinz01 <[email protected]>
merlinz01
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
- Coverage 71.95% 70.92% -1.04%
==========================================
Files 91 113 +22
Lines 8001 8900 +899
==========================================
+ Hits 5757 6312 +555
- Misses 2244 2588 +344 ☔ View full report in Codecov by Sentry. |
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
|
Fix DCO, rebase please? |
Signed-off-by: merlinz01 <[email protected]>
merlinz01
force-pushed
the
implement-async-ssl_assert_hostname
branch
from
4552db2
to
7752471
Compare
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
|
CI failed in lint, |
Signed-off-by: merlinz01 <[email protected]>
There was a problem hiding this comment.
Looks like a legit test failure with a newer Python version?
_ TestAIOHttpConnection.test_nowarn_when_test_uses_https_if_verify_certs_is_off _
self = <test_opensearchpy.test_async.test_connection.TestAIOHttpConnection object at 0x7f8f401a8740>
async def test_nowarn_when_test_uses_https_if_verify_certs_is_off(self) -> None:
with warnings.catch_warnings(record=True) as w:
con = AIOHttpConnection(
use_ssl=True, verify_certs=False, ssl_show_warn=False
)
await con._create_aiohttp_session()
> assert w == []
E assert [<warnings.WarningMessage object at 0x7f8f304f7ef0>] == []
E
E Left contains one more item: <warnings.WarningMessage object at 0x7f8f304f7ef0>
E
E Full diff:
E - []
E + [
E + <warnings.WarningMessage object at 0x7f8f304f7ef0>,
E + ]
test_opensearchpy/test_async/test_connection.py:231: AssertionError
|
Testing with Python 3.12 works for me, can you rerun the test? |
Failed again, it's not a fluke, there's some warning but the contents don't show up in the log (maybe start there to see the error) https://github.com/opensearch-project/opensearch-py/actions/runs/11846183040/job/33061554546?pr=843. |
|
|
|
OK, so it's a deprecated parameter on |
Yes please, we do want tests to pass :) |
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
|
Thanks @dblock! I don't see where the release schedule for clients is documented, so wondering when this change will be available. |
Description
Implements the
ssl_assert_hostnameparameter forAsyncOpenSearch().Issues Resolved
Closes #842
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.