Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HybridQueryBuilderTests to decouple types from K-NN library #979

Open
owaiskazi19 opened this issue Nov 8, 2024 · 3 comments
Open
Assignees
Labels

Comments

@owaiskazi19
Copy link
Member

Is your feature request related to a problem?

Coming from #859. Refactored HybridQueryTests and HybridQueryPhaseSearcherTests in #977. Similarly, need to decouple knn for HybridQueryBuilderTests.

What solution would you like?

A clear and concise description of what you want to happen.

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@martin-gaievski martin-gaievski changed the title [FEATURE] Refactor HybridQueryBuilderTests to decouple types from K-NN library Refactor HybridQueryBuilderTests to decouple types from K-NN library Nov 8, 2024
@martin-gaievski martin-gaievski added the good first issue Good for newcomers label Nov 8, 2024
@yuye-aws
Copy link
Member

The PR #977 has been merged. What else do we need to do?

@owaiskazi19
Copy link
Member Author

The PR #977 has been merged. What else do we need to do?

PR was for other 2 different test classes.

@martin-gaievski
Copy link
Member

Scope for this issue is removal of compile time dependency from
HybridQueryTests and HybridQueryBuilderTests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog (Hot)
Development

No branches or pull requests

4 participants