From 58add11901a3dc32dc8c31edbfce82befc2eab73 Mon Sep 17 00:00:00 2001 From: Hailong Cui Date: Tue, 17 Sep 2024 00:43:03 +0800 Subject: [PATCH] upgrade upload-artifact to version 3 (#1252) * upgrade upload-artifact to version 4 Signed-off-by: Hailong Cui * add overwrite as true Signed-off-by: Hailong Cui * use v3 as v4 need node.js 20 Signed-off-by: Hailong Cui --------- Signed-off-by: Hailong Cui --- .github/workflows/bwc-test-workflow.yml | 3 ++- .../workflows/docker-security-test-workflow.yml | 6 ++++-- .github/workflows/multi-node-test-workflow.yml | 3 ++- .github/workflows/security-test-workflow.yml | 3 ++- .github/workflows/test-and-build-workflow.yml | 15 +++++++++------ 5 files changed, 19 insertions(+), 11 deletions(-) diff --git a/.github/workflows/bwc-test-workflow.yml b/.github/workflows/bwc-test-workflow.yml index 656aea4cc..dc905d65d 100644 --- a/.github/workflows/bwc-test-workflow.yml +++ b/.github/workflows/bwc-test-workflow.yml @@ -26,8 +26,9 @@ jobs: echo "Running backwards compatibility tests..." ./gradlew bwcTestSuite - name: Upload failed logs - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: failure() with: name: logs + overwrite: 'true' path: build/testclusters/indexmanagementBwcCluster*/logs/* diff --git a/.github/workflows/docker-security-test-workflow.yml b/.github/workflows/docker-security-test-workflow.yml index 6511ebfec..de3d83ea9 100644 --- a/.github/workflows/docker-security-test-workflow.yml +++ b/.github/workflows/docker-security-test-workflow.yml @@ -84,10 +84,11 @@ jobs: echo "Security plugin is NOT available skipping this run as tests without security have already been run" fi - name: Upload failed logs - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: failure() with: name: logs + overwrite: 'true' path: build/testclusters/integTest-*/logs/* - name: Collect docker logs on failure uses: jwalton/gh-docker-logs@v2 @@ -96,8 +97,9 @@ jobs: - name: Tar logs run: tar cvzf ./logs.tgz ./logs - name: Upload logs to GitHub - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: failure() with: name: logs.tgz + overwrite: 'true' path: ./logs.tgz diff --git a/.github/workflows/multi-node-test-workflow.yml b/.github/workflows/multi-node-test-workflow.yml index f23add7cd..e3c1bb911 100644 --- a/.github/workflows/multi-node-test-workflow.yml +++ b/.github/workflows/multi-node-test-workflow.yml @@ -53,8 +53,9 @@ jobs: chown -R 1000:1000 `pwd` su `id -un 1000` -c "./gradlew integTest -PnumNodes=3 ${{ env.TEST_FILTER }}" - name: Upload failed logs - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 if: failure() with: name: logs + overwrite: 'true' path: build/testclusters/integTest-*/logs/* diff --git a/.github/workflows/security-test-workflow.yml b/.github/workflows/security-test-workflow.yml index d88750bda..8dc6eb19c 100644 --- a/.github/workflows/security-test-workflow.yml +++ b/.github/workflows/security-test-workflow.yml @@ -42,8 +42,9 @@ jobs: chown -R 1000:1000 `pwd` su `id -un 1000` -c "./gradlew integTest -Dsecurity=true -Dhttps=true --tests '*IT'" - name: Upload failed logs - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 if: failure() with: name: logs + overwrite: 'true' path: build/testclusters/integTest-*/logs/* diff --git a/.github/workflows/test-and-build-workflow.yml b/.github/workflows/test-and-build-workflow.yml index 73c24da42..a5dc4c0cb 100644 --- a/.github/workflows/test-and-build-workflow.yml +++ b/.github/workflows/test-and-build-workflow.yml @@ -56,10 +56,10 @@ jobs: chown -R 1000:1000 `pwd` su `id -un 1000` -c "./gradlew build ${{ env.TEST_FILTER }}" - name: Upload failed logs - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: ${{ failure() }} with: - name: logs + name: logs-${{ matrix.java }}-${{ matrix.feature }} path: build/testclusters/integTest-*/logs/* - name: Create Artifact Path run: | @@ -71,10 +71,12 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} # This step uses the upload-artifact Github action: https://github.com/actions/upload-artifact - name: Upload Artifacts - uses: actions/upload-artifact@v1 + # v4 requires node.js 20 which is not supported + uses: actions/upload-artifact@v3 with: - name: index-management-plugin-ubuntu-latest + name: index-management-plugin-ubuntu-latest-${{ matrix.java }} path: index-management-artifacts + overwrite: 'true' test-and-build-windows-macos: env: @@ -127,7 +129,8 @@ jobs: cp ./build/distributions/*.zip index-management-artifacts # This step uses the upload-artifact Github action: https://github.com/actions/upload-artifact - name: Upload Artifacts - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: - name: index-management-plugin-${{ matrix.os }} + name: index-management-plugin-${{ matrix.os }}-${{ matrix.java }} path: index-management-artifacts + overwrite: 'true'