Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Search dv only IP masks #16662

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d4d70d8 from #16628.

* search dv only ip masks

Signed-off-by: mikhail-khludnev <[email protected]>

* search dv only ip masks: changes

Signed-off-by: Mikhail Khludnev <[email protected]>

* drop fancy closures

Signed-off-by: mikhail-khludnev <[email protected]>

* drop fancy closures. one more

Signed-off-by: mikhail-khludnev <[email protected]>

* fix unit tests; add some more dvOnly

Signed-off-by: mikhail-khludnev <[email protected]>

* drop skipping dvOnly in 2.x

Signed-off-by: mikhail-khludnev <[email protected]>

* drop redundant brackets

Signed-off-by: mikhail-khludnev <[email protected]>

* extract conditions

Signed-off-by: mikhail-khludnev <[email protected]>

* asserts

Signed-off-by: mikhail-khludnev <[email protected]>

* spotless apply

Signed-off-by: mikhail-khludnev <[email protected]>

* bring back skip before

Signed-off-by: mikhail-khludnev <[email protected]>

* combine asserts

Signed-off-by: mikhail-khludnev <[email protected]>

* inline, copy-paste

Signed-off-by: mikhail-khludnev <[email protected]>

---------

Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: Mikhail Khludnev <[email protected]>
Co-authored-by: mikhail-khludnev <[email protected]>
(cherry picked from commit d4d70d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❕ Gradle check result for d2e90c6: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (df175d1) to head (d2e90c6).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ava/org/opensearch/index/mapper/IpFieldMapper.java 85.71% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16662      +/-   ##
============================================
+ Coverage     71.80%   71.83%   +0.02%     
+ Complexity    65414    65413       -1     
============================================
  Files          5314     5314              
  Lines        305205   305210       +5     
  Branches      44469    44473       +4     
============================================
+ Hits         219163   219239      +76     
+ Misses        67805    67715      -90     
- Partials      18237    18256      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 407a70d into 2.x Nov 16, 2024
62 checks passed
@github-actions github-actions bot deleted the backport/backport-16628-to-2.x branch November 16, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant