chore: use portal by default in avatar menu #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm why is the portal flaking the menu :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bright uses the AvatarMenu in the app NavBar, which is a fairly typical use case. It is as sticky bar, which creates its own stacking context. Unrelated ancestor props like maxHeight or overflow then cause issues for the AvatarMenu.
Solution
There's rarely a reason not to use Menu with Portal. This changes
AvatarMenuto do that, without changing the component signature.Alternative considered
Accept a new custom prop like
withPortal. Rejected because it is custom, and it feels acceptable to deny users the option to not use portal.