Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of text inside Attachment dropzone #586

Open
jia1 opened this issue Nov 30, 2023 · 1 comment · May be fixed by #713
Open

Allow overriding of text inside Attachment dropzone #586

jia1 opened this issue Nov 30, 2023 · 1 comment · May be fixed by #713
Assignees

Comments

@jia1
Copy link
Member

jia1 commented Nov 30, 2023

Is your feature request related to a problem? Please describe.

Yes, I am unable to meet my product design requirements. We would like to change the text inside Attachment dropzone. We also wish to have links in the text, so allowing us to specify a ReactNode somewhere is preferable.

Describe the solution you'd like

I would like the Attachment component to accept a ReactNode either via props or as children. Jia Chin also suggests sharding the Attachment component out into smaller components like Attachment.Dropzone etc.

Describe alternatives you've considered

I was not able to find any prop to do this, and placing a child component inside Attachment did not work either (it doesn't accept children).

Additional context

[Screenshot] We wish to override the text that's highlighted in the screenshot below:

Screenshot 2023-11-30 at 12 09 12 PM
@karrui karrui self-assigned this May 8, 2024
@karrui
Copy link
Collaborator

karrui commented May 8, 2024

Thanks for the wait. I finally have some bandwidth, and will be working on it this week :P

@karrui karrui linked a pull request May 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants