Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clickhouse]Look into removing use of both statementId and statement_id in queries #548

Open
Leobouloc opened this issue Dec 27, 2023 · 0 comments
Open

[Clickhouse]Look into removing use of both statementId and statement_id in queries #548

Leobouloc opened this issue Dec 27, 2023 · 0 comments

Comments

@Leobouloc
Copy link
Contributor

Feature Request

Currently, clickhouse queries by id use both statement_id and statementId as tested below.

ralph/tests/backends/lrs/test_clickhouse.py

Lines 59 to 60 in b1ad3c8

"statementId": "test_id",
"statement_id": "test_id",

Perhaps this could be simplified to only use one, for clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Ralph roadmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Leobouloc