Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openconfig-bgp-policy:asn/repeat-n needs clarification about default values #1194

Open
mkh-arista opened this issue Oct 2, 2024 · 0 comments

Comments

@mkh-arista
Copy link

mkh-arista commented Oct 2, 2024

Commit e020ce4 by @aashaikh added asn as the value used in conjunction with repeat-n to prepend the AS path with, but did not specify behaviour if asn is present but repeat-n is not.

Sane options are:

  1. Refuse to accept asn without repeat-n
  2. Prepend asn once
  3. Do nothing

Option 1 could be implemented using when statement, but now it's probably too late for it may break existing configurations.

Option 2 essentially gives repeat-n two default values: 0 when asn is empty, and 1 otherwise: not great theoretically, though understandable practically. Whether this is a problem is subjective.

Option 3 seems safe unless 2 is already popular in the wild, which is hard for me to tell.

In any case, something needs to be done to prevent implementations divergence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant