Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the description of tunnel-src-ip-address leaf in openconfig-aft-common.yang file #1040

Closed
krishna-juniper opened this issue Jan 30, 2024 · 2 comments · Fixed by #1038

Comments

@krishna-juniper
Copy link

https://github.com/openconfig/public/blob/master/release/models/aft/openconfig-aft-common.yang#L272

Description of tunnel-src-ip-address is confusing. It can be used to populate gre tunnel src address. can we update the description to make it specific to EVPN/VXLAN?

#1038 (comment)

@dplore
Copy link
Member

dplore commented Jan 30, 2024

Agreed that the current description allows for broad use and interpretation for this leaf. #570 which added this leaf only contemplated the VXLAN use case. In concept it seems like any encapsulation that uses IP as the outer header might be expected to populate this leaf.

I'd appreciate feedback from the community on the feasibility of supporting this given the current description, or if we should narrow it to only certain use cases which could include only VXLAN.

@robshakir
Copy link
Contributor

I think that this is a reasonable backwards compatible change, but what we perhaps should do is restructure the contents of this container to be grouped by tunnel type per @romeyod's previous suggestion.

This will be backwards incompatible and has impact in gRIBI, but we could start this work now and just mark the other leaves as deprecated. The suggestions thus far would be to create mpls, and vxlan, ip-in-ip already has its own container, and gre will based on #1038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants