Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management Screen: Prevent Root User from Being Selected with Table Header Checkbox #123

Open
FarahRasheed1 opened this issue Jul 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@FarahRasheed1
Copy link
Contributor

Describe the bug

When the table header checkbox is selected, the root user is also selected along with other users. This can lead to unintended modifications to the root user, such as disabling or deleting the root user.

To Reproduce

  1. Navigate to the 'User Management' screen under 'Security and Access.'
  2. Click on the table header checkbox to select all users.
  3. Observe that the root user is selected along with other users, making it possible to delete or disable the root user.

Expected behavior

To prevent unintended modifications to the root user, the root user should not be selected when the table header checkbox is selected. Users must explicitly select the root user to make any modifications.

Screenshots

image

@FarahRasheed1 FarahRasheed1 changed the title User Management Screen: Root user being selected along with all local users from table header checkbox User Management Screen: Prevent Root User from Being Selected with Table Header Checkbox Jul 9, 2024
@FarahRasheed1
Copy link
Contributor Author

FarahRasheed1 commented Jul 9, 2024

Bench test results:

Before bugfix:

PreFixBenchTestResults.mp4

After bugfix:

PostFixBenchTestResults.mp4

@gtmills gtmills added the enhancement New feature or request label Jul 9, 2024
@gtmills
Copy link
Member

gtmills commented Jul 11, 2024

PreFixBenchTestResults.mp4

This did not upload/display..

When the table header checkbox is selected, the root user is also selected along with other users.

This is a table and a selectall gets all the rows... If we do something special here, this table behaves differently than other tables..

@mdmillerii
Copy link

Also I will request that the root user should be deselected when the checkbox rubselects all other users.

@FarahRasheed1 an alternative for this safeguard to consider would be to warn with a pop-up confirmation / cancel dialogue when the root user is selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants