fix: fix #5101 by checking if destroyed #5102
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5102 +/- ##
==========================================
- Coverage 93.18% 93.16% -0.03%
==========================================
Files 315 315
Lines 8086 8088 +2
Branches 1617 1618 +1
==========================================
Hits 7535 7535
- Misses 551 553 +2
|
pichlermarc
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Thanks for working on a fix for this - is there any way to hit this code-path in a test? 🤔
Without a test it's unfortunately difficult to grasp if this fix is effective.
Maybe I'm wrong, but shouldn't the error handler below ensure that no error is unhandled for the req? Could it be that the error is actually somewhere in compressAndSend() (seeing that the error is EPIPE in the #5101) 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #5101
Short description of the changes
check if destroyed before calling
destroyType of change
Please delete options that are not relevant.