Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: check if pioneer-package dependency is peer-dependency in build tool #58

Open
antoniave opened this issue Jun 21, 2023 · 0 comments

Comments

@antoniave
Copy link
Member

antoniave commented Jun 21, 2023

A pioneer-package should always be added as a peer dependency, not as a "normal" dependency. Especially when publishing packages.

In the build-pioneer-cli tool we already check if all necessary dependencies are declared in the package.json.

The idea is to additionally check if all pioneer-package dependencies are declared as peer dependecies and not as "normal" dependencies.

@mbeckem mbeckem transferred this issue from open-pioneer/trails-starter Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant