Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: use material wrapped markdown (fixes #7686) #7709

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mutugiii
Copy link
Member

@Mutugiii Mutugiii commented Nov 1, 2024

Fixes #7686

Upgrade from td-markdown to td-flavored-markdown(material flavoured)
td-markdown: https://teradata.github.io/covalent/v8/#/components/markdown-parser/overview
td-flavored-markdown: https://teradata.github.io/covalent/v8/#/components/flavored-markdown/overview

td-markdown
image

td-flavored-markdown
image

@Mutugiii Mutugiii linked an issue Nov 1, 2024 that may be closed by this pull request
Copy link
Member

@RheuX RheuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

image

image

I think i've tried on a lot of the markdown that are available (team, exams, enterprise, health, resources, etc), i mostly just did a check of everything here using the same format. Although, if someone were to put a checkbox or a table in the achievement (for whatever reason), this is the outcome

image

Not sure if this is relevant to this PR, since its probably also an issue from beforehand

also, i just realize that most of my table can't be italicized or bold

This is before the flavored markdown
image

So maybe the framework couldn't handle any markdown components (it's not even bolding and italicize, its also putting down links or any similar format)

Screenshot 2024-11-01 at 12 27 13 PM

Covalent Flavored Markdown component

It should support markdown components, ill also probably try to see if this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdown: editor should pick up on checkboxes
3 participants