-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OCDS documentation more portable #266
Comments
Hi 👋🏼 . I found this issue while browsing for Read the Docs issues and I wanted to comment some things 😄
This limitation was removed and that
There is a completely new beta approach to this version switcher that's called "addons". Currently, the version switcher is added at the bottom-right of the page. You can see an example at https://test-builds.readthedocs.io/en/latest/ Also, we are working on a way to heavily customize the version switcher from the Sphinx theme itself by subscribing to a JavaScript
I understand you need to run custom commands for non-Sphinx catalogs. Read the Docs now supports this by using
This was also rewritten with the new addons approach and they work on any Sphinx theme, even on different documentation tools, like Docusaurus: https://test-builds.readthedocs.io/en/docusaurus/
The If you want to trigger the "Read the Docs Search addon" when clicking on any other input (e.g. the default search input that Sphinx uses) you can add a small JavaScript code to trigger the correct event on
As I mentioned before, we are working on giving the theme authors access to all the data in a JSON structure so they can integrate nicely with the theme as shown in this PR: readthedocs/sphinx_rtd_theme#1526. Again, feedback welcome. Let me know if this helps you with the decision about whether or not using Read the Docs for your docs 🎉 |
Thank you for this information! |
If we switch to DocSearch open-contracting/ocds-index#7, the deployment process would then just be copying the built pages to the server. We still need our own hosting for:
/projects/
path component instead of/profiles/
.We currently need our own build system for:
current_lang
logic for linking to translated schema and codelists. OCDS for PPPs doesn't use it though - in conf.py, it instead writes these files to both the language's root and to a_static
path that is ignored by git.util/add_translation_notes.py
. We should hook this into Sphinx using thebuild-finished
event instead: https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx-core-eventsIf we address all the above, it could be possible to host on ReadTheDocs or elsewhere. To opt-out of ads, see https://readthedocs.org/accounts/gold/
For older instructions on setting up ReadTheDocs: https://ocds-standard-development-handbook.readthedocs.io/en/latest/profiles/technical/integrations.html
If using ReadTheDocs, we should configure:
We can also eliminate
test_common.py
as we can trust that the build, search and language switcher work. (Note: When we switch to sphinx-inline-tabs instead of our custom jsoninclude JS, we can also eliminatetest_docs.py
.)I think the main question is how well ReadTheDocs' features are supported when using a custom theme. Docs for integration with:
readthedocs-sphinx-search
pydata/pydata-sphinx-theme#202Note that the version/locale switchers need to be updated for the new theme anyway open-contracting/standard#1254 (comment). If we decide to switch to RTD, we can avoid doing this work twice.
The text was updated successfully, but these errors were encountered: