Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache invalidation fix #94

Open
sideninja opened this issue Oct 11, 2022 · 2 comments
Open

Cache invalidation fix #94

sideninja opened this issue Oct 11, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@sideninja
Copy link
Contributor

sideninja commented Oct 11, 2022

There's an issue with cache invalidation. Current logic invalidates the cache based on the block height and the number of executions in the database. If a number of executions is lower in the database than in the cached emulator block height then it obviously needs to be reset. The problem is that there's an edge case where other executions are done after reset so the height matches.

@DylanTinianov DylanTinianov added the bug Something isn't working label Oct 11, 2022
@DylanTinianov DylanTinianov moved this from 🔖 Ready to 🏗 In progress in 🌊 Flow 4D Oct 13, 2022
@DylanTinianov DylanTinianov moved this from 🏗 In progress to 🔖 Ready in 🌊 Flow 4D Oct 13, 2022
@sideninja sideninja assigned sideninja and unassigned DylanTinianov Oct 20, 2022
@sideninja
Copy link
Contributor Author

For now we scaled down the replica and will revisit this in the future.

@gregsantos
Copy link

Address on FF migration

@gregsantos gregsantos moved this from 🔖 Ready for Pickup to 🧊Ice Box in 🌊 Flow 4D Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants