Make event encoding configurable over grpc #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
requested review from
janezpodhostnik,
sideninja,
chasefleming,
nvdtf and
jribbink
as code owners
peterargue
commented
May 30, 2024
| @@ -103,6 +113,11 @@ type Client struct { | |||
| grpc *BaseClient | |||
| } | |||
|
|
|||
| // RPCClient returns the underlying gRPC client. | |||
| func (c *Client) RPCClient() RPCClient { | |||
There was a problem hiding this comment.
this isn't strictly needed here, but it provides some flexibility for users in the future to break out into a raw grpc request when the sdk doesn't expose some needed/new functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #666
Description
Currently, event encoding is hard coded to use CCF. This was added to switch to the smaller size payloads. However, it does not support backwards compatibility mode needed by some clients during the Cadence 1.0 transition.
This PR updates the grpc client code to allow setting the event encoding for the client. During the transition, users can switch to use JSONCDC.
For contributor use:
masterbranchFiles changedin the Github PR explorer