Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Forwarding Rules Manager implementation contract instead of the storage contract #34

Open
akolotov opened this issue May 27, 2021 · 0 comments
Open

Use Forwarding Rules Manager implementation contract instead of the storage contract #34

akolotov opened this issue May 27, 2021 · 0 comments
Labels
bug Something isn't working deployment related to the deployment process external modules Related to contracts which are external w.r.t. to the omnibridge contracts fwd-rules Related to the Forwarding Rules Management

Comments

@akolotov
Copy link
Collaborator

Since the Forwarding Rules Manager specific to particular mediator it does not make sense to re-use its proxy storage address. Consider re-use the implementation contract instead.

omnibridge-nft/deploy/src/omnibridge_nft/home.js

Line 87 in 9702180

console.log('\n[Home] Using existing Forwarding Rules Manager: ', forwardingRulesManager)

@akolotov akolotov added bug Something isn't working deployment related to the deployment process external modules Related to contracts which are external w.r.t. to the omnibridge contracts fwd-rules Related to the Forwarding Rules Management labels May 27, 2021
@k1rill-fedoseev k1rill-fedoseev mentioned this issue Jul 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working deployment related to the deployment process external modules Related to contracts which are external w.r.t. to the omnibridge contracts fwd-rules Related to the Forwarding Rules Management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akolotov