Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No ability to re-use existing gas limit manger during deployment #33

Open
akolotov opened this issue May 27, 2021 · 0 comments
Open

No ability to re-use existing gas limit manger during deployment #33

akolotov opened this issue May 27, 2021 · 0 comments
Labels
deployment related to the deployment process external modules Related to contracts which are external w.r.t. to the omnibridge contracts gas-limit Related to the AMB Gas Limit management invalid This doesn't seem right

Comments

@akolotov
Copy link
Collaborator

Although there is an ability to re-use an existing Forwarding Rules Manager during the deployment, this ability, most probably, was missed for the Gas Limit manager:

omnibridge-nft/deploy/src/omnibridge_nft/home.js

Line 77 in 9702180

let forwardingRulesManager = HOME_FORWARDING_RULES_MANAGER === false ? ZERO_ADDRESS : HOME_FORWARDING_RULES_MANAGER

@akolotov akolotov added invalid This doesn't seem right deployment related to the deployment process gas-limit Related to the AMB Gas Limit management external modules Related to contracts which are external w.r.t. to the omnibridge contracts labels May 27, 2021
@k1rill-fedoseev k1rill-fedoseev mentioned this issue Jul 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployment related to the deployment process external modules Related to contracts which are external w.r.t. to the omnibridge contracts gas-limit Related to the AMB Gas Limit management invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akolotov