Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple staging support #959

Open
xmo-odoo opened this issue Oct 7, 2024 · 0 comments
Open

multiple staging support #959

xmo-odoo opened this issue Oct 7, 2024 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Oct 7, 2024

Currently the mergebot assumes each branch only has one staging going on, and this assumption is leveraged in several places (usually by checking a branch's active_staging_id for information).

This is likely non-trivial, but would be a requirement for advanced staging modes e.g.

  • incremental staging (Incremental / continuous staging #951)
  • optimistic concurrent staging (create staging 2 on top of staging 1 if there are enough PRs waiting)
  • concurrent split staging (Stage concurrent splits #497) as well as pessimistic concurrent staging (the same without a split, assumes the current staging is going to fail)
  • pessimistic splitting (stages a staging and its splits at the same time such that one of the splits can be merged if the main staging fails)
  • ...

Changing this would likely require some sort of intermediate staging strategy object, which can bundle a bunch of stagings and provides relevant query operations. Note that this also impacts batches and PRs as we dereference their stagings e.g. to cancel the current staging if they're part of that on r- or w/e.

@xmo-odoo xmo-odoo moved this to accepted in Mergebot Oct 7, 2024
@xmo-odoo xmo-odoo added this to Mergebot Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: accepted
Development

No branches or pull requests

1 participant