Check if the PR is blocked before pinging about awaiting action #930
Labels
Comments
xmo-odoo
added a commit
that referenced
this issue
Sep 6, 2024
The FW reminder is useful to remind people of the outstanding forward ports they need to process, as taking too long can be an issue. They are, however, not useful if the developer has already done everything, the PR is ready and unblocked, but the mergebot has fallen behind and has a hard time catching up. In that case there is nothing for the developer to do, so pinging them is not productive, it's only frustrating. Fixes #930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In case the mergebot falls behind on the queue (because it has to merge a thousand broken PRs because everything is urgent for whatever demo is upcoming). it can start PRs which have been validated and approved but it just hasn't merged yet.
That's... putting salt on the wound to put it mildly, as the developers would have appreciated the PR be long merged.
Examples:
The text was updated successfully, but these errors were encountered: