Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log merge errors as errors. #910

Open
xmo-odoo opened this issue Jul 12, 2024 · 0 comments
Open

Don't log merge errors as errors. #910

xmo-odoo opened this issue Jul 12, 2024 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

Logged errors should be issues attributable to the mergebot e.g. something went wrong with the mergebot.

A PR not being mergeable because of a conflict or an incorrect configuration is not a mergebot error, even if exceptions are used internally to propagate the information. It should be logged as a failure of the PR but that's it.

@xmo-odoo xmo-odoo moved this to accepted in Mergebot Jul 12, 2024
@xmo-odoo xmo-odoo moved this from accepted to done in Mergebot Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: done
Development

No branches or pull requests

1 participant