Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][ALL VERSIONS]: OWL error when a page is Google translated and OWL modifies a list of elements #1631

Open
kebeclibre opened this issue Aug 8, 2024 · 1 comment

Comments

@kebeclibre
Copy link
Contributor

In odoo:

  • have a x2m editable list
  • google translate the page in chrome (it seems to replace the targeted text with elements)
  • click on a cell to edit its content
  • CRASH in VLIST

I don't think it is easily fixable, but it had to be noted.

For the record: it odoo's task 4063314

@ged-odoo
Copy link
Contributor

ged-odoo commented Sep 2, 2024

yeah, that is not really fixable. Owl (and some (all?) other vdom-based framework as well!) uses empty text nodes as anchor to keep track of various dom locations. It is (currently) not supported to modify the dom of a owl-managed html element. However, maybe we can think of improvements. Maybe a nicer error message. Or some kind of recovery mode: if owl detects that the patching operation crashed, it could silently replace the (modified) content by the template content (so, giving back the control to owl). Not sure about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants