Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same BNFC version #25

Closed
1 task
deemp opened this issue Jan 10, 2024 · 5 comments
Closed
1 task

Use the same BNFC version #25

deemp opened this issue Jan 10, 2024 · 5 comments
Assignees
Labels
(dev environment) Related to development environment

Comments

@deemp
Copy link
Member

deemp commented Jan 10, 2024

  • Make the version of BNFC fixed for devs so that changes to grammar don't produce larger than necessary diffs (like this one).

BNFC 2.9.6 doesn't exist on Hackage. The latest version is 2.9.5.

It also doesn't exist in our current resolver.

https://github.com/objectionary/normalizer/blob/c1b2a139e981f589b69f7e98b32c58db9c731f72/stack.yaml#L1

https://www.stackage.org/nightly-2023-12-14

However, I see comments that some files were generated by bnfc 2.9.6.

https://github.com/objectionary/normalizer/blob/c1b2a139e981f589b69f7e98b32c58db9c731f72/eo-phi-normalizer/src/Language/EO/Phi/Syntax/Abs.hs#L1

https://github.com/objectionary/normalizer/blob/c1b2a139e981f589b69f7e98b32c58db9c731f72/eo-phi-normalizer/src/Language/EO/Phi/Syntax/Print.hs#L1

@aabounegm
Copy link
Collaborator

That was my bad. I had BNFC built from source (master branch, which has the unreleased v2.9.6) from when I was contributing a PR. I have now removed my local build and installed v2.9.5 using Stack.
I see that the generated files now use v2.9.5 since #22, so I think we can close this issue.

@deemp deemp reopened this Jan 12, 2024
@deemp
Copy link
Member Author

deemp commented Jan 12, 2024

Can we make use of full positions version? Related to #19.

If yes, pls, add your version to extra-deps in stack.yaml and make a PR.

@aabounegm
Copy link
Collaborator

Do we really need it (at least right now)?
Even if so, I think #19 is enough and no need to keep this unrelated issue open.

@fizruk
Copy link
Collaborator

fizruk commented Jan 23, 2024

Can we close this issue?

@deemp
Copy link
Member Author

deemp commented Jan 24, 2024

I don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(dev environment) Related to development environment
Projects
None yet
Development

No branches or pull requests

3 participants