-
Notifications
You must be signed in to change notification settings - Fork 303
WebSphere Liberty support missing in spring-security-web #530
Comments
For now, I created an own version of spring-security that solves this issue with WebSphere Liberty. |
If you could fix that it would be awesome if you could provide the fix as PR to spring-security-web or as diff so someone else can do that for you. |
Any update on this one? Can we get your fix and integrate that? |
Sorry for the huge delay in responding to your request. The attached patch file contains my fix. The fix is not clean since it introduces a dependency to the Liberty API. So one of the following two things have to be done:
Patch (diff file): patch.txt |
I am still unsure about our JEE app server strategy. To be honest all app servers are dead and betting on them is a dead end causing technical dept. Versions of Java (8,9,10,11,...) as well as libraries and frameworks are evolving faster and faster. A (classic) JEE app server is a jail that wont let you catch up and will end in a security disaster over time. There might be a future with MicroProfiles but if you ask me the future belongs to spring-boot, docker and stuff like that. Finally its the time to convince your customers to go away from all the 1990 solutions. However, to communicate an honest expectation: do not expect support from the key players of OASP/devonfw on this topic. |
I provided the patch following your request ... not expecting anything. |
Spring-security-web provides a filter called WebSpherePreAuthenticatedProcessingFilter that should allow to use the authentication information provided by WebSphere. However, this code was designed to run on traditional WebSphere and does not work on WebSphere Liberty. The reason is that traditional WebSphere provides access to the UserRepository through JNDI while WebSphere Liberty has an API for that (Security public APIs). The same issue has already been spotted by other Liberty users before: javax.naming.NameNotFoundException: UserRegistry
Since we need to support WebSphere Liberty in our project, we would need to fix that part of spring-security-web. OASP-2.2 uses version 4.0,4, and I already double-checked that the current release 4.2.1 does not provide a fix. The respective file is DefaultWASUsernameAndGroupsExtractor.java.
Assuming we will be able to fix this, what should be the best approach to do so: push it back to spring-security, create an own version of spring-security, or anything else?
Besides that: is there a reason why OASP is not yet using the current release of spring-security?
The text was updated successfully, but these errors were encountered: