Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also recognize C-h in sub-keymaps #187

Closed
minad opened this issue Mar 22, 2021 · 4 comments
Closed

Also recognize C-h in sub-keymaps #187

minad opened this issue Mar 22, 2021 · 4 comments

Comments

@minad
Copy link
Contributor

minad commented Mar 22, 2021

When I press M-x embark-act C C-h I don't get a completing-read prompter. This is the equivalent of #139 ;)

Besides that everything seems to work for me now with the Embark prompter. I like it! Not really, but I still like it 😆

@oantolin
Copy link
Owner

Not really, but I still like it

Most other things should be working now. 🤞🏽

@oantolin
Copy link
Owner

This is the equivalent of #139 ;)

Wow, that bug just won't let me off the hook, huh?

@rswgnu
Copy link

rswgnu commented Mar 29, 2021

Minibuffer completions used '?' to show completions so I would advise you stick to that as a default and then that would open up using C-h normally in embark keymaps.

@oantolin
Copy link
Owner

@rswgnu In my personal configuration I unbind C-h and use ? instead, precisely because several useful commands are on the C-h prefix. So I definitely agree with you. The reason I picked C-h is for consistency with normal prefix keys: if you need a reminder of the suffixes, you press C-h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants