Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

RARBG now includes an EXE file to deter mirroring #9

Open
ChrislyBear-GH opened this issue Jan 28, 2019 · 2 comments
Open

RARBG now includes an EXE file to deter mirroring #9

ChrislyBear-GH opened this issue Jan 28, 2019 · 2 comments

Comments

@ChrislyBear-GH
Copy link

RARBG now includes and exe file called "RARBG_DO_NOT_MIRROR.exe", which should deter mirroring, because automated crawlers will filter the releases out because it could be a virus.

See: https://torrentfreak.com/rarbg-adds-exe-files-to-torrents-but-no-need-to-panic-190126/

FakeDetector "correctly" marks downloads containting "RARBG_DO_NOT_MIRROR.exe" as bad. But as the article states, it's just a text file to dupe crawlers, etc.

Please add an option to expressedly allow specific file names, so that downloads won't get thrown out just because someone like RARBG is trolling us.

Chris

@fovert
Copy link

fovert commented Feb 3, 2019

A quick fix is to change line 116 to add the file name to the allowed list:
allowNames = [ 'RARBG_DO_NOT_MIRROR', 'rename', 'Rename' ]
And change line line 121 to not immediately exclude '.exe':
if ext in exExtensions and not name in allowNames:
I'm not sure why '.exe' is checked independently on 121 as the extension is already in the exExtensions list. Are there cases where 'rename.exe' is a bad file that needs to be excluded?

@ChrislyBear-GH
Copy link
Author

Sure, I could fix this myself, but I'd rather stay on the official version because I don't want to port any custom changes over into each new version.

That's why I'm suggestion an option, so all the users can exclude certain files without branching off a custom version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants