Enable strip query string for regex or selectable per redirection

[ilicmarko]

Is your feature request related to a problem? Please describe.

If you have a regexmatch you usually get the whole match. For example:

From	To
/old(.*)	/new$1

This would essentially remap all requests from old. The "problem" is if you have Strip Query String from 404s turned off, which usually is the case, you would get duplicate query string.

Describe the solution you would like

There are essentially three solution that come to mind at the moment:

• Always strip params for regex match (maybe problematic for backwards compatibility)
• Add a global settings to enable stripping for regex (essentially splitting the current option into two).
• Add the option for each redirect. Therefore it can be chosen from redirect to redirect.

Describe alternatives you have considered

The idea was to maybe capture everything up till the ? but that maybe problematic if there are anchors.

([^?]+)e.

[khalwat]

We can't reliably strip a query string from a regex match, because the ? has special meaning in a RegEx.

Also yes, it would break backwards compatibility.

You can come up with a RegEx that will match everything up to the next ? though, which would effectively strip the query string as well. If you do care about anchors, you can have another capture group that captures any anchors, and combine them for the final URL.

[ilicmarko]

My ideas was not to strip query string from Regex it was to disable the option of adding (appending) them to the URL for certain redirects.

Global Settings: Strip Query String from 404s false

Original	From	To	Strip	Final
domain.com/foo?gclid=1	/foo	/bar	false (default)	domain.com/bar?gclid=1
domain.com/foo?gclid=1	/foo	/bar	true	domain.com/bar
domain.com/foo?gclid=1	/foo(.*)	/bar$1	false (default)	domain.com/bar?gclid=1?gclid=1
domain.com/foo?gclid=1	/foo(.*)	/bar$1	true	domain.com/bar?gclid=1

It would impact this if, where you can check the value for each redirection individually.

craft-retour/src/services/Redirects.php

Lines 251 to 256 in 2b006a4

	if (Retour::$settings->preserveQueryString) {
	$request = Craft::$app->getRequest();
	if (!empty($request->getQueryStringWithoutPath())) {
	$dest .= '?' . $request->getQueryStringWithoutPath();
	}
	}

@khalwat

Thinking about the solution with regex you wrote that might not be possible. Because you are appending the query string and if I append the anchor the query string will always come after the anchor which is not valid.

/foo/bar?hello#world -> I capture the parts in regex -> /baz/bar/#world -> Retour appends query /baz/bar/#world?hello.

Making this impossible to achieve. This is way I would like to Enable stripping per route. Because in most cases I don't need it but in (almost all) regex cases I do need it.

[khalwat]

Ah I see, sorry I misunderstood. So you want that option to have a per-redirect override, essentially?

[ilicmarko]

Exactly.

[jan-dh]

Would love something like this as well, would be very handy to pass around UTM tags etc. from a marketing perspective

[Abromeit]

+1