Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking for create_extension_spec.py #72

Open
pauladkisson opened this issue Jul 28, 2023 · 0 comments
Open

Error checking for create_extension_spec.py #72

pauladkisson opened this issue Jul 28, 2023 · 0 comments

Comments

@pauladkisson
Copy link

pauladkisson commented Jul 28, 2023

Current Behavior

Users can place NWBGroups such as TimeSeries into other specs such as NWBDatasetSpec. The .yaml files are rendered without error and when these incorrectly defined extension types are used, HDMF throws hard-to-interpret error:

TypeError: GroupBuilder.set_dataset: incorrect type for 'builder' (got 'GroupBuilder', expected 'DatasetBuilder')

Expected Behavior

It would be really nice if create_extension_spec.py automatically checked the neurodata_types that are used in the extension and ensured that the NWBSpecs are fed the appropriate neurodata_types. Ex:

TypeError: NWBDataSpec: incorrect type for 'neurodata_type_inc' (got 'NWBGroup' expected 'NWBDataset')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant