Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comma support for weight input #56

Open
christirichards opened this issue Jul 29, 2021 · 1 comment
Open

Add comma support for weight input #56

christirichards opened this issue Jul 29, 2021 · 1 comment
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior.
Milestone

Comments

@christirichards
Copy link
Member

We've received a few reports of users not being able to use a comma in place of a decimal point. See below:

"I live in Sweden and my keyboard is set up to use a comma (,) when writing a decimal point - e.g. when documenting my weight, my numeric keyboard only allows me to separate fractions of a kilogram with a comma. i.e. 85,1 kg instead of 85.1 kg. Unfortunately, the app won’t register the comma! I have just discovered this today."

@marc-medley marc-medley self-assigned this Jul 29, 2021
@marc-medley marc-medley added the bug Indicates an unexpected problem or unintended behavior. label Jul 29, 2021
@marc-medley marc-medley added this to the v3.2.11 milestone Aug 2, 2021
@marc-medley marc-medley linked a pull request Aug 2, 2021 that will close this issue
@marc-medley
Copy link
Member

marc-medley commented Aug 11, 2021

Note: regional number support ties into data entry, HealthKit sync, database normalized form and import/export.

This issue also has a dimension where the user can select the number format region separate to the different from the typical selected app language region.

Status: a cohesive solution regional number representation for data imput, HealthKit sync, database normalized form and import/export has been implemented and checked in. The stored data is normalized to a binary kg Double. Unit tests have between added to verify correct function of the solutioned as languages and regions are added.

Next step is to complete testing and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants