add msg if API response can't be converted

[konstruktoid]

This PR makes the return msg a bit more helpful when the API response can't be converted to json.

Pre- and post-patch:

$ ansible-playbook -ihosts cert.yml 2>/dev/null

PLAY [Clusters_Info playbook] **********************************************************************************************************************

TASK [Getting all clusters - validate_certs True] ***********************************************************************************************************************
fatal: [prism]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python"}, "changed": false, "error": null, "msg": "Failed to convert API response to json", "response": null, "status_code": -1}
...ignoring

TASK [Print clusters] ******************************************************************************************************
ok: [prism] => {
    "msg": {
        "ansible_facts": {
            "discovered_interpreter_python": "/usr/bin/python"
        },
        "changed": false,
        "error": null,
        "failed": true,
        "msg": "Failed to convert API response to json",
        "response": null,
        "status_code": -1
    }
}

TASK [Getting all clusters - validate_certs False] *******************************************************************************************************************
ok: [prism]

TASK [Print clusters] *********************************************************************************************
ok: [prism] => {
    "msg": "API version: 3.1"
}

PLAY RECAP **************************************************************************************************************
prism                      : ok=4    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=1

$ ansible-playbook -ihosts cert.yml 2>/dev/null

PLAY [Clusters_Info playbook] ****************************************************************************************************************************

TASK [Getting all clusters - validate_certs True] ****************************************************************************************************************************
fatal: [prism]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python"}, "changed": false, "error": null, "msg": "Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:618)>", "response": null, "status_code": -1}
...ignoring

TASK [Print clusters] *****************************************************************************************************************************
ok: [prism] => {
    "msg": {
        "ansible_facts": {
            "discovered_interpreter_python": "/usr/bin/python"
        },
        "changed": false,
        "error": null,
        "failed": true,
        "msg": "Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:618)>",
        "response": null,
        "status_code": -1
    }
}

TASK [Getting all clusters - validate_certs False] *************************************************************************************************************************
ok: [prism]

TASK [Print clusters] *****************************************************************************************************
ok: [prism] => {
    "msg": "API version: 3.1"
}

PLAY RECAP **************************************************************************************************************
prism                      : ok=4    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=1

[bhati-pradeep]

Thank you for raising PR

[konstruktoid]

Added a try:/catch: and I assume that any error message will be > 2, but it will skip any empty ("") messages.

[marathe-99]

Is that problem is resolved??

[bhati-pradeep]

Is that problem is resolved??

Not yet @marathe-99, this will go in next maintenance release.

[bhati-pradeep]

Thats fine, let it be 0 so that we can back trace any error message in our product code base.

[konstruktoid]

done

[bhati-pradeep]

@konstruktoid What happens if msg key is not present in info ? I am just thinking it can cause TypeError ? As len(None) can cause that. Does ansible's fetch_url confirms that msg will be always a string ?

[bhati-pradeep]

Since you are only checking ValueError.

[konstruktoid]

yeah, perhaps i should just simplify it like https://github.com/nutanix/nutanix.ansible/pull/486/files#diff-be0a07cfc89126d4e28a8fbd2d2716635f9ab383eb08f54b504429dd647853efL399-L400

[bhati-pradeep]

@konstruktoid there is a small syntax issue. Please check latest comment

Check comments

[george-ghawali]

LGTM

[bhati-pradeep]

LGTM