Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code cleanup] Remove Organization get or create for existing users in authentication backend #504

Open
qbey opened this issue Nov 4, 2024 · 0 comments

Comments

@qbey
Copy link
Collaborator

qbey commented Nov 4, 2024

Code cleanup

Is your feature request related to a problem or unsupported use case? Please describe.
The #469 PR introduces a temporary feature to link already existing user without an Organization to an Organization at authentication stage.
This Issue is a kind reminder to cleanup the code when all existing user have an Organization.

Describe the solution you'd like
The OIDCAuthenticationBackend.get_or_create_user method should not try to update the organization for User without any. We should remove this code when all user in database have an Organization.
We should also make the Organization field mandatory on the User model and the Team model.

Discovery, Documentation, Adoption, Migration Strategy
Once all User/Team have an organization, we can safely make the cleanup.

Do you want to work on it through a Pull Request?
I will do it when data in staging/production is ready for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant