Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Configurable context path or prefix URL #328

Open
ricecooker opened this issue Aug 23, 2021 · 2 comments
Open

Feature Request: Configurable context path or prefix URL #328

ricecooker opened this issue Aug 23, 2021 · 2 comments

Comments

@ricecooker
Copy link

By default commuter runs on http://hostname:4000/

Could we add a parameter such as COMMUTER_URL_PREFIX that could change the URL?

As an example if I were to do this:

export COMMUTER_URL_PREFIX=commuter/

Then commuter would respond to this:
http://hostname:4000/commuter/

I have a build server with nginx in front that I'd like to host commuter so people can easily lookup their papermill jobs that run.

@captainsafia
Copy link
Member

Thanks for sharing this recommendation, @ricecooker! Are you interested in submitting a PR for this? Happy to point you to the right places.

@ricecooker
Copy link
Author

Sure, I'm open to exploring. NodeJS is not usually my cup of tea but I'm happy to try learn. I noticed some references to baseUrl in the codebase and this feature seems to already be on the roadmap (sorry!).

For anyone else needing this now, I found https://github.com/line/jnotebook_reader that does support this. I'd like to stick with nteract/commuter since we use papermill a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants