Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.dev.ts suffix for dev-only plugins/middlewares/tasks #2866

Open
1 task done
sandros94 opened this issue Nov 9, 2024 · 3 comments
Open
1 task done

.dev.ts suffix for dev-only plugins/middlewares/tasks #2866

sandros94 opened this issue Nov 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@sandros94
Copy link
Contributor

Describe the feature

Inspired by #1849 and the work done at #2272 it would be nice to make the env suffix such as .dev.ts or .prod.ts a convention also available on plugins and possibly others like middlewares and tasks.

Additional information

  • Would you be willing to help implement this feature?
@sandros94
Copy link
Contributor Author

Am I wrong or could this be fully done inside src/core/scan.ts by just filtering inside each scan function?

Should we limit this suffix to dev and prod?

@pi0 pi0 added enhancement New feature or request and removed pending triage labels Nov 11, 2024
@pi0
Copy link
Member

pi0 commented Nov 11, 2024

Inside scan.ts we can extract env conditions and in builder when filtering plugins, filter them based on them. so yes, first step is updating scan.ts. Feel free to open PR and we can iterte though it.

@sandros94
Copy link
Contributor Author

Inside scan.ts we can extract env conditions and in builder when filtering plugins, filter them based on them. so yes, first step is updating scan.ts. Feel free to open PR and we can iterte though it.

Perfect! Thanks, in the upcoming days I'll start drafting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants