Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create ci check to verify that new added versions exist #26

Open
NachoVazquez opened this issue Apr 25, 2021 · 2 comments
Open

create ci check to verify that new added versions exist #26

NachoVazquez opened this issue Apr 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@NachoVazquez
Copy link
Contributor

NachoVazquez commented Apr 25, 2021

What is the motivation/use case for changing the behavior?

Once a new version is added or a change is made to the existing version there is no check to verify if the action truly exists.

Describe the solution you'd like

I think it would be interesting to perform a fetch to npm and verify that each version exists.

This could be made directly using a script or using some custom or pre-existing GH Action

Describe alternatives you've considered

  • create a full package.json, set the CI with a matrix to override the version and run an npm i

Additional context

UPDATE:

Currently we are not protected against adding or modifying packages versions that don't exist.

For example, if adding Angular 13 support and using the wrong version for @angular/cli, anyone using our action will see the action fail because the provided version does not exist.

With the suggested check we at least verify that the versions of the packages are valid.

@NachoVazquez NachoVazquez added the enhancement New feature or request label Apr 25, 2021
@LayZeeDK
Copy link
Member

LayZeeDK commented Apr 25, 2021

Please elaborate. I don't understand this issue.

@NachoVazquez
Copy link
Contributor Author

I added an update

@NachoVazquez NachoVazquez moved this to Backlog in Lumberjack Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants