Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update supported PostgreSQL versions #49240

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 13, 2024

Summary

12 is now EOL but 17 was released and should be supported and tested.

Checklist

12 is now EOL but 17 was released and should be supported and tested.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added enhancement pending documentation This pull request needs an associated documentation update feature: database Database related DB labels Nov 13, 2024
@susnux susnux added this to the Nextcloud 31 milestone Nov 13, 2024
@susnux susnux added 3. to review Waiting for reviews and removed pending documentation This pull request needs an associated documentation update labels Nov 13, 2024
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I use MySQL 9.x since many months without an issue :D

@nickvergessen
Copy link
Member

CI fails :P

@susnux
Copy link
Contributor Author

susnux commented Nov 13, 2024

I use MySQL 9.x since many months without an issue :D

They have so short lifespan, I would wait for 9.7 lts. Otherwise we need to update the workflows regularly, no?

@nickvergessen
Copy link
Member

I was more talking about the warning in the setup check.
Doctrine is also testing against the latest 9.x:
https://github.com/doctrine/dbal/blob/4.2.x/.github/workflows/continuous-integration.yml#L375

So I guess it would be nice to add it.

So ~once per our major. Sounds good enough?

@susnux
Copy link
Contributor Author

susnux commented Nov 13, 2024

So ~once per our major. Sounds good enough?

Well, yes that makes sense. So we can spot issues early.
But would you also add this to the setup check?

@susnux susnux merged commit dea6bd7 into master Nov 13, 2024
189 checks passed
@susnux susnux deleted the feat/postgres-13-17 branch November 13, 2024 11:20
@wrenix
Copy link

wrenix commented Nov 15, 2024

"backport requested" is checked but i do not see any backport

@susnux
Copy link
Contributor Author

susnux commented Nov 16, 2024

"backport requested" is checked but i do not see any backport

Just means backports are requested if needed. We do not backport features so there is no backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: database Database related DB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PostgreSQL 17
4 participants