Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we need these defaultConfigs? #69

Closed
huww98 opened this issue Jan 27, 2021 · 2 comments · Fixed by #464
Closed

Why do we need these defaultConfigs? #69

huww98 opened this issue Jan 27, 2021 · 2 comments · Fixed by #464
Labels
1. to develop Accepted and waiting to be taken care of

Comments

@huww98
Copy link
Contributor

huww98 commented Jan 27, 2021

All these defaultConfigs are already included in nextcloud docker image, right? https://github.com/nextcloud/docker/tree/master/.config

And some configs in this repo is not up-to-date. e.g. redis.config.php in this repo does not handle redis password.

In my mind, we should remove all these defaultConfigs from this repo, and just use the configs packed in the docker image.

@tvories
Copy link
Collaborator

tvories commented Mar 10, 2021

A few changes have been pushed to update redis password settings. Would you be interested in submitting a PR reflect the defaults?

@jessebot
Copy link
Collaborator

jessebot commented Jul 25, 2024

We need the default configs because we currently overwrite the config dir with other *config.php files, in addition to the default configs, which would overwrite the configs. For instance, we support adding additional config files. We could maybe use a projected volume to solve this, but for now, I've opened #464 which will take care of getting all the configs up to date.

Info on projected volumes, but not sure if this would actually work: https://kubernetes.io/docs/concepts/storage/projected-volumes/

If this issue gets closed if/when #464 is merged, please feel free to test if projected volumes work, and if they do, we'd gladly review a PR for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of
Projects
None yet
3 participants