Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Widen dependency requirements #6213

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ChristophWurst
Copy link
Contributor

@ChristophWurst ChristophWurst commented Nov 13, 2024

☑️ Resolves

Npm audit can not update dependencies with a strict requirement. E.g. at nextcloud/mail#10342 npm audit fix tries to update the vulnerable debounce but can't without also updating nc/vue. This relaxes the requirement to allow newer minor/patch versions of the same dependency while keeping this package unchanged.

🖼️ Screenshots

N/a

🚧 Tasks

  • Code

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ChristophWurst ChristophWurst added bug Something isn't working 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Nov 13, 2024
@ChristophWurst ChristophWurst self-assigned this Nov 13, 2024
@ChristophWurst
Copy link
Contributor Author

/backport to next

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a mistake, thank you!

@susnux susnux merged commit 3b4f54b into master Nov 13, 2024
19 checks passed
@susnux susnux deleted the fix/deps/widen-dependency-ranges branch November 13, 2024 16:41
Copy link

backportbot bot commented Nov 13, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/6213/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5794b0b9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6213/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants