Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade checker needs to re-run previous command on success in order to guarantee updates #90

Open
deajan opened this issue Sep 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@deajan
Copy link
Contributor

deajan commented Sep 5, 2024

Since we now distribute non single binary files, our previous upgrade path doesn't work anymore.

We need to run upgrader before anything else in order to prevent later program issues interfering with updates.
But, we also need a guarantee that the initial program call will be done.
We must find (a good) way for this pseudo code:

copy current dist to old dist
move new dist to current dist
run with --version
on succees
run new version with sys.argv[1:]
on failure
delete current dist
move old dist to current dist

@deajan deajan added this to the 3.0 milestone Sep 5, 2024
@deajan deajan self-assigned this Sep 5, 2024
@deajan deajan added the bug Something isn't working label Sep 5, 2024
@deajan
Copy link
Contributor Author

deajan commented Sep 7, 2024

Currently in testing stage but implemented in v3.0.0-rc5

@deajan
Copy link
Contributor Author

deajan commented Sep 17, 2024

Now tested in master for windows.
Currently rebuilding binaries for more tests, especially with legacy arches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant