Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chatllama]Puzzled about the update of the critic model #338

Open
zhuweipg99 opened this issue Apr 28, 2023 · 0 comments
Open

[chatllama]Puzzled about the update of the critic model #338

zhuweipg99 opened this issue Apr 28, 2023 · 0 comments

Comments

@zhuweipg99
Copy link

When I looked into the compute the value loss in trainer.py line 1012-1017,

value_loss_clipped = old_values + (values - old_values).clamp(-critic_eps_clip, critic_eps_clip)
value_loss1 = (value_loss_clipped - rewards) ** 2
value_loss2 = (values - rewards) ** 2
value_loss = torch.max(value_loss1, value_loss2).mean()

I think the values and rewards are equal to the old_values, cause they use the same model to compute the score.
I will be very grateful if you guys can answer my confuse.

@zhuweipg99 zhuweipg99 changed the title Puzzled about the update of the critic model [chatllama]Puzzled about the update of the critic model Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant