The NATS url needs to manually percent decode the username and the password

[paolobarbolini]

We've had this issue reported for lettre and I believe nats.rs has it too
lettre/lettre#931

The url crate doesn't percent decode the username and the password, so credentials containing characters like # don't work. Here the credentials should be percent decoded:

nats.rs/async-nats/src/lib.rs

Lines 1415 to 1427 in 8c783e0

	pub fn username(&self) -> Option<&str> {
	let user = self.0.username();
	if user.is_empty() {
	None
	} else {
	Some(user)
	}
	}
	/// Returns the optional password in the url.
	pub fn password(&self) -> Option<&str> {
	self.0.password()
	}

[Jarema]

Thanks for letting us know.

The impact should be really small, as if you're using ConnectOptions with username and password, we are not passing credentials in URL, but in Connect protocol message.

Only case that affects Rust NATS client is when someone manually passes username and password in the NATS url.